Skip to content

gh-131152: Remove unused imports in tests #131169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

gh-131152: Remove unused imports in tests #131169

wants to merge 3 commits into from

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Mar 12, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 12, 2025
Closed
@StanFromIreland StanFromIreland changed the title gh-131152: Remove unused imports in stdlib gh-131152: Remove unused imports in tests Mar 12, 2025
@picnixz
Copy link
Member

picnixz commented Mar 12, 2025 •
edited
Loading

#131153 and #131154 are already taking care of some changes; I would advise commenting those PRs if additional imports need to be removed.

auvipy
auvipy suggested changes Mar 13, 2025
View reviewed changes
Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on the last comment, it appears to be better to close it and communicate in two already opened pr about remaining unused imports. thanks for your efforts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy requested changes

@jaraco jaraco Awaiting requested review from jaraco jaraco is a code owner

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StanFromIreland @picnixz @auvipy