-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-63882: Comment out empty test_minidom
tests
#128948
base: main
Are you sure you want to change the base?
gh-63882: Comment out empty test_minidom
tests
#128948
Conversation
This is the second item from the action items proposed by @terryjreedy (#63882 (comment))
|
@terryjreedy (I can’t request a review in any other way) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of them are included. Looks good to me!
Why are we using |
@picnixz This was requested by Terry in his comment on the issue. I guess it is easier to find them? |
test_minidom
tests
I think I'll me comfortable with an explicit "TODO" since we also used Ok, I've seen that #63882 (comment) is actually the comment that explained the different steps to do (it was hidden by GH). So there's a plan to implement something. If the tests are meant to be implemented in a short future, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double hashes, '##', are an old standard for (temporarily) commenting out code with something other than normal code comments. I added a "# TODO" comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the first 3 tests 1 line as with all the others.
Given the absence of immediate replacements, this was considered better than deletion.