Skip to content

Postpone module.__loader__ deprecation to Python 3.16 #126482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 6, 2024

Related to #122255:

There was a flaw in implementation of the warnings so we should first fix the warnings in 3.14 and prolong the deprecation period until 3.16.

See also #123011.


📚 Documentation preview 📚: https://cpython-previews--126482.org.readthedocs.build/

@hugovk hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Nov 6, 2024
@hugovk hugovk requested a review from willingc as a code owner November 6, 2024 10:26
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting core review labels Nov 6, 2024
Copy link

@RupeshBhandari RupeshBhandari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on catching this one.

@hauntsaninja hauntsaninja merged commit 450db61 into python:main Nov 10, 2024
42 checks passed
@miss-islington-app
Copy link

Thanks @hugovk for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @hugovk and @hauntsaninja, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 450db61a78989c5a1f1106be01e071798c783cf9 3.13

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2024
)

(cherry picked from commit 450db61)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 10, 2024

GH-126637 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 10, 2024
hauntsaninja pushed a commit to hauntsaninja/cpython that referenced this pull request Nov 10, 2024
(cherry picked from commit 450db61)
@bedevere-app
Copy link

bedevere-app bot commented Nov 10, 2024

GH-126638 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 10, 2024
@bedevere-app
Copy link

bedevere-app bot commented Nov 10, 2024

GH-126638 is a backport of this pull request to the 3.13 branch.

hauntsaninja pushed a commit that referenced this pull request Nov 10, 2024
…6482) (#126637)

Postpone `module.__loader__` deprecation to Python 3.16 (GH-126482)
(cherry picked from commit 450db61)

Co-authored-by: Hugo van Kemenade <[email protected]>
hauntsaninja added a commit that referenced this pull request Nov 10, 2024
…6482) (#126638)

Postpone `module.__loader__` deprecation to Python 3.16 (#126482)

(cherry picked from commit 450db61)

Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk hugovk deleted the docs-postpone-module-loader-deprecation branch November 10, 2024 09:44
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants