Skip to content

Commit

Permalink
Fix bad grammar and import docstring for split/rsplit (GH-32381)
Browse files Browse the repository at this point in the history
  • Loading branch information
rhettinger authored Apr 8, 2022
1 parent 1c2fddd commit d6fb104
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 22 deletions.
34 changes: 21 additions & 13 deletions Objects/clinic/unicodeobject.c.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 16 additions & 9 deletions Objects/unicodeobject.c
Original file line number Diff line number Diff line change
Expand Up @@ -13155,19 +13155,26 @@ PyUnicode_Split(PyObject *s, PyObject *sep, Py_ssize_t maxsplit)
str.split as unicode_split
sep: object = None
The delimiter according which to split the string.
None (the default value) means split according to any whitespace,
and discard empty strings from the result.
The separator used to split the string.
When set to None (the default value), will split on any whitespace
character (including \\n \\r \\t \\f and spaces) and will discard
empty strings from the result.
maxsplit: Py_ssize_t = -1
Maximum number of splits to do.
Maximum number of splits (starting from the left).
-1 (the default value) means no limit.
Return a list of the words in the string, using sep as the delimiter string.
Return a list of the substrings in the string, using sep as the separator string.
Note, str.split() is mainly useful for data that has been intentionally
delimited. With natural text that includes punctuation, consider using
the regular expression module.
[clinic start generated code]*/

static PyObject *
unicode_split_impl(PyObject *self, PyObject *sep, Py_ssize_t maxsplit)
/*[clinic end generated code: output=3a65b1db356948dc input=606e750488a82359]*/
/*[clinic end generated code: output=3a65b1db356948dc input=906d953b44efc43b]*/
{
if (sep == Py_None)
return split(self, NULL, maxsplit);
Expand Down Expand Up @@ -13338,14 +13345,14 @@ PyUnicode_RSplit(PyObject *s, PyObject *sep, Py_ssize_t maxsplit)
/*[clinic input]
str.rsplit as unicode_rsplit = str.split
Return a list of the words in the string, using sep as the delimiter string.
Return a list of the substrings in the string, using sep as the separator string.
Splits are done starting at the end of the string and working to the front.
Splitting starts at the end of the string and works to the front.
[clinic start generated code]*/

static PyObject *
unicode_rsplit_impl(PyObject *self, PyObject *sep, Py_ssize_t maxsplit)
/*[clinic end generated code: output=c2b815c63bcabffc input=12ad4bf57dd35f15]*/
/*[clinic end generated code: output=c2b815c63bcabffc input=ea78406060fce33c]*/
{
if (sep == Py_None)
return rsplit(self, NULL, maxsplit);
Expand Down

0 comments on commit d6fb104

Please sign in to comment.