Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Add ci for ubuntu using gh-action #223

Merged
merged 6 commits into from
Nov 16, 2020

Conversation

RatanShreshtha
Copy link
Member

No description provided.

@RatanShreshtha RatanShreshtha requested a review from pquentin May 14, 2020 14:48
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #223 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   98.72%   98.65%   -0.07%     
==========================================
  Files          22       22              
  Lines        3204     3204              
==========================================
- Hits         3163     3161       -2     
- Misses         41       43       +2     
Impacted Files Coverage Δ
src/ahip/_collections.py 100.00% <ø> (ø)
src/ahip/exceptions.py 100.00% <ø> (ø)
src/ahip/util/retry.py 99.60% <ø> (ø)
src/ahip/util/timeout.py 100.00% <ø> (ø)
src/ahip/util/wait.py 78.49% <100.00%> (ø)
src/ahip/util/url.py 99.35% <0.00%> (-0.65%) ⬇️

@pquentin pquentin closed this May 14, 2020
@pquentin pquentin reopened this May 14, 2020
@pquentin
Copy link
Member

I don't understand :/

@pquentin
Copy link
Member

pquentin commented Nov 4, 2020

@RatanShreshtha I spend hours on this in the context of urllib3, see urllib3/urllib3#2035 for the fix. Maybe the issue is different here since we don't have PySocks support, I'm not sure.

@RatanShreshtha
Copy link
Member Author

I am thinking about using https://github.com/nektos/act on my machine to figure out what is happening.

@pquentin
Copy link
Member

pquentin commented Nov 6, 2020

By the way @njsmith agreed to drop Python 2 support: python-hyper/h11#114

If the test_source_address issue is only showing up there, that could help! (I'm seeing it on urllib3 too by the way)

@RatanShreshtha
Copy link
Member Author

Then I am going to remove python 2 from the list of python version and update the PR

@pquentin
Copy link
Member

pquentin commented Nov 6, 2020

Yes, let's just update the CI we'll focus on removing the Python 2 code later

@pquentin
Copy link
Member

pquentin commented Nov 6, 2020

You only need to remove 2.7 from .travis.yml and we'll be good 👍

@RatanShreshtha
Copy link
Member Author

RatanShreshtha commented Nov 6, 2020

I think PR has set for windows with python 2.7, maybe @njsmith need to disable that

@pquentin pquentin merged commit e198149 into python-trio:master Nov 16, 2020
@pquentin
Copy link
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants