Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload wheels to scientific-python-nightly-wheels index #8236

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

lysnikolaou
Copy link
Contributor

Related to #8199.

In order for this to work we're going to need a secret named PILLOW_NIGHTLY_UPLOAD_TOKEN. @hugovk Did you already create it? If so, what's its name?

@radarhere
Copy link
Member

Your original idea was ANACONDA_ORG_UPLOAD_TOKEN, and that was what he requested of aclark4life

@lysnikolaou
Copy link
Contributor Author

Thanks for the pointer @radarhere! Updated now.

@radarhere
Copy link
Member

For my curiosity - can this be removed once Python 3.13 final is released on October 1?

@lysnikolaou
Copy link
Contributor Author

Hmm, that's a good question. Many people will start testing only after the final release, so we'll have free-threading-related bugfixes after that as well, and nightlies will continue to be helpful then. So my feeling is that we can go on uploading nightlies after final and only stop when threading-related bug reports start slowing down significantly. What do you think?

Co-authored-by: Andrew Murray <[email protected]>
# │ │ │ ┌───────────── month (1 - 12 or JAN-DEC)
# │ │ │ │ ┌───────────── day of the week (0 - 6 or SUN-SAT)
# │ │ │ │ │
- cron: "42 1 * * 0,3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wheels build takes up a fair amount of CI time/runners.

@radarhere Is 01:42 UTC going to interfere with when you're active? We can move it to your night/inactive time if you like.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thought, but that's not a problem for me personally - especially since d83c7b3 skips the aarch64 jobs.

@hugovk
Copy link
Member

hugovk commented Jul 16, 2024

Hmm, that's a good question. Many people will start testing only after the final release, so we'll have free-threading-related bugfixes after that as well, and nightlies will continue to be helpful then. So my feeling is that we can go on uploading nightlies after final and only stop when threading-related bug reports start slowing down significantly. What do you think?

Yes, I think it will be helpful too.

@hugovk hugovk added the Free-threading PEP 703 support label Jul 16, 2024
@aclark4life
Copy link
Member

Your original idea was ANACONDA_ORG_UPLOAD_TOKEN, and that was what he requested of aclark4life

Will do! Stay tuned …

@aclark4life
Copy link
Member

@hugovk And … can't find my secret key or emergency kit, can you please start a recovery for me and I'll be sure to save this time? Sorry about that.

@hugovk
Copy link
Member

hugovk commented Jul 17, 2024

Done!

Recovery started, pending action by Jeffrey A. Clark.

@aclark4life
Copy link
Member

Done!

Recovery started, pending action by Jeffrey A. Clark.

Thanks, also done! Do we still need any/all of the other secrets ?

Screenshot 2024-07-17 at 7 08 57 AM

I have an Anaconda Cloud account too: https://anaconda.org/aclark

@radarhere
Copy link
Member

CODECOV_ORG_TOKEN, yes.

token: ${{ secrets.CODECOV_ORG_TOKEN }}

TIDELIFT_API_KEY was added for #5762 (comment). We don't need it anymore as of #6739

GH_PAT was added for #4071 (comment), which I don't think ever materialised.

Copy link
Member

@radarhere radarhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reran the wheels job thinking it would make use of the new secret, but I forgot that it was only used by workflow dispatch and schedule.

I guess merging and seeing if this works is the next step.

@hugovk
Copy link
Member

hugovk commented Jul 17, 2024

Let's try it!

Edit: manually triggered: https://github.com/python-pillow/Pillow/actions/runs/9975952588

@hugovk hugovk merged commit 024fa51 into python-pillow:main Jul 17, 2024
23 checks passed
@lysnikolaou
Copy link
Contributor Author

It seems that the QEMU job was started as well. Opened #8243 to fix that. Does it make sense to stop everything and rerun it after that follow-up PR has been merged as well?

@hugovk
Copy link
Member

hugovk commented Jul 17, 2024

Yes, let's save two hours of CI time, I've cancelled it.

@hugovk
Copy link
Member

hugovk commented Jul 17, 2024

#8243 is merged, here's a new run: https://github.com/python-pillow/Pillow/actions/runs/9978963564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Free-threading PEP 703 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants