Adding try/except workaround when Pendulum tries to treat environment variable local timezone as a filepath #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iority local timezone
…d the same as the timezone exists, attempts to read it as a file even if it is not a timezone file
egbutter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Addresses bug #467. Adding try/except workaround in
local_timezone.pyand test for the environment variable functionality. Whenpendulumincorrectly tries to treat an environment variable local timezone as a filepath instead of a string, carry on and try to treat the string as a timezone itself, instead.masterbecause this is a bugfix for current productionpendulum==2.1.0