Skip to content

Conversation

kurtmckee
Copy link
Contributor

@kurtmckee kurtmckee commented Jun 23, 2025

This PR introduces the following changes:

  • Fix deprecated pre-commit stage names.

    When pre-commit install is run, it currently throws a deprecation regarding the stage names in the config file. This is now fixed.

  • Update the pyupgrade hook to its latest version, and update its target syntax version to Python 3.9+.

  • Remove flynt as a pre-commit hook.

    Its functionality is handled by the pyupgrade hook.

  • Migrate from local pre-commit hooks to standard, hosted pre-commit hooks.

    This change is necessary because not all git-related tooling runs pre-commit hooks with the same activated virtual environment that the Poetry dev dependencies are installed in.

Taken together, these changes bring the pre-commit hook configuration up-to-date, and make it possible to enable pre-commit.ci for the repo if you choose to do so (and I highly recommend doing so!).

Note

I've split the commits up so that it can be reviewed commit-by-commit. This isolates the manual and automatic changes so that they can be reviewed in smaller chunks.

Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.91%. Comparing base (49109f7) to head (e77bf1a).
⚠️ Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
openapi_spec_validator/validation/protocols.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
- Coverage   92.09%   91.91%   -0.19%     
==========================================
  Files          24       24              
  Lines         759      742      -17     
  Branches       80       83       +3     
==========================================
- Hits          699      682      -17     
+ Misses         42       39       -3     
- Partials       18       21       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant