typing fixes and improvements

[dlax]

A few commits to make mypy happy in the code base.

[Richardk2n]

Thank you.
The reason for List and Dict was because you are not able to use the builtins in older python versions.
Do you happen to know, since when this is possible? (To make sure we still support the versions we claim to support)

Did you figure out, why the call overload is complaining?
I never did. It looks fine to me.

[dlax]

The reason for List and Dict was because you are not able to use the builtins in older python versions. Do you happen to know, since when this is possible? (To make sure we still support the versions we claim to support)

This is possible since Python 3.9, so fine for us.

Did you figure out, why the call overload is complaining? I never did.

This is because of the **windows_flag; but in fact, I found a better way to fix those, see last commit.

[Richardk2n]

Ok good.

Can you elaborate a bit?
I am fine with this solution if it works, but am not quite sure why it does.
Also, the #type ignore in that line should be removable now?
The tests also have these, so maybe use the typed dict there as well.

[dlax]

Can you elaborate a bit? I am fine with this solution if it works, but am not quite sure why it does.

The previous type hint for windows_flag: dict[str, int] resulted in a subprocess.run(**windows_flag: int) call (from typing pov) but the function does not accept arbitraty **kwargs: int. By changing to a TypedDict, we can keep the **windows_flag syntax but now the call is subprocess.run(creationflags: int), which is allowed.

Also, the #type ignore in that line should be removable now?

No, it's still needed because, on linux, subprocess has no CREATE_NO_WINDOW attribute; I added an error code for that.

The tests also have these, so maybe use the typed dict there as well.

I changed the test to reuse the value from plugin module.

[Richardk2n]

Ok, thx for the explanation.
Can you please add a comment to the line about the ignoring being necessary even so this never can produce an error?

It seems like you did not run the black formatter.

[dlax]

Done

[dlax]

Fixed the flake8 error, sorry about that.

[Richardk2n]

line 73 still is too long?

[dlax]

line 73 still is too long?

fixed...

[Richardk2n]

Thank you for your contribution.