Skip to content

Fix packaging checks and simplify CI #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

janbrasna
Copy link

Due to a bug in twine<6.0.1 not reading the correct metadata using wildcards thus failing the tox -e packaging steps, I've moved the pin from 5.1.x to 6.1.x to include some additional compatibility with packaging dependencies.

This also bumps outdated actions/* and generally simplifies and speeds up the workflow.

Inlining the h2spec step also allows for getting rid of its install script and exposing the access token.

NB: To currently pass ruff/mypy checks, I had to fix runtime-cast-value (TC006) by quoting the type expressions in h2/stream occurrences of cast()

Logs: actions/runs/14669502174

@@ -7,10 +7,9 @@ on:
branches: ["master"]

jobs:
tox:
test:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmh this was perhaps not exactly fortunate, as the id seems to be defined in repository branch protection settings as required checks… in that case feel free to revert this back:

Suggested change
test:
tox:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant