Repository navigation
Fix dlopen for Python 3.16 - #289
Closed
emmatyping wants to merge 1 commit into
Closed
emmatyping wants to merge 1 commit into
emmatyping wants to merge 1 commit into
Conversation
Python 3.16 removes the deprecated Py_FileSystemDefaultEncoding. Python 3.14 provides a PyConfig_Get() API to query the filesystem encoding in it's place. This change uses the new API on 3.14+.
Author
|
Apologies, I should have looked through open PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.16 removes the deprecated Py_FileSystemDefaultEncoding. Python 3.14 provides a PyConfig_Get() API to query the filesystem encoding in it's place. This change uses the new API on 3.14+. I can also do this on 3.16+ if you prefer.
This was caught by snake_pit, a project I've created to test Python 3.16 against popular Python projects to understand when we break downstream projects. Given cffi is popular, and used by many popular projects, I would like to fix this error early so we can try to run regression tests against cffi and projects that depend on it.
AI disclosure, this was reviewed by an LLM.