-
Notifications
You must be signed in to change notification settings - Fork 316
feat(dev-hub) Api Reference V2 #3252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
f204072 to
f5fc046
Compare
| } | ||
|
|
||
| function escapeQuotes(text: string): string { | ||
| return text.replaceAll('"', String.raw`\"`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way for all this logic in the file to be organized such that it's easier to understand what's happening here?
There's already a level of abstraction from fumadocs and I feel like it's impossible for someone to understand what's going on here.
Can you also document everything for example like a higher level overview what this whole thing does and why do we need this and how to use this. Maybe even mention it in the readme if it's something we need to run at build time. It's much better to be over explicit about what something does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to give you a walkthrough if needed
16126a4 to
ad7ad37
Compare
Summary
Rationale
How has this been tested?