Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend LinuxBlockDevice to use information from lsblk and add method to return all block devices on the system #760

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Extend LinuxBlockDevice to use information from lsblk and add method to return all block devices on the system #760

wants to merge 2 commits into from

Conversation

fsuba
Copy link

@fsuba fsuba commented Apr 9, 2024

The purpose of this PR is to give us more information about the block devices on a system. lsblk is part of the util-linux package, the same package as blockdev. With the information from lsblk, we can easily return all the block devices found on a system.

martinhoyer
martinhoyer approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@martinhoyer martinhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is pretty cool. lsblk -J option is available even on older versions fwiw.
It would be nice to have some feedback from the maintainers here :) Does it fit-in to testinfra codebase as is, or is there something that needs to be changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinhoyer martinhoyer martinhoyer approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsuba @martinhoyer