Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor karateclub dependency #58

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

ffl096
Copy link
Member

@ffl096 ffl096 commented Oct 18, 2024

Unfortunately we cannot have a direct source dependency when packaging for PyPI, which we need for a more up-to-date karateclub (see #49).
Lets use a "standard" dependency on karateclub for now and ask the user to manually install the source version.

@ffl096 ffl096 added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Oct 18, 2024
@ffl096 ffl096 added this to the 0.1.0 milestone Oct 18, 2024
@ffl096 ffl096 self-assigned this Oct 18, 2024
@ffl096 ffl096 force-pushed the frantzen/karateclub-dependency branch from ff110f0 to 49f13fb Compare October 18, 2024 11:31
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (3d82209) to head (eddf08c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files           8        8           
  Lines         177      177           
=======================================
  Hits          171      171           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffl096 ffl096 force-pushed the frantzen/karateclub-dependency branch from 49f13fb to eddf08c Compare October 18, 2024 11:34
@ffl096 ffl096 merged commit 5ddce99 into main Oct 18, 2024
14 checks passed
@ffl096 ffl096 deleted the frantzen/karateclub-dependency branch October 18, 2024 12:51
@ffl096 ffl096 mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant