Repository navigation
feat: switch provider to Miruro - #1993
Dhairya3391 wants to merge 9 commits into
Conversation
Co-authored-by: GPT-6.1 Sol
port19x
left a comment
There was a problem hiding this comment.
Keep the carefully crafted http error codes please.
Maybe you can explain with an example why we need slot handling.
Also { # breaks formating, don't do that
miruro_media looks rough
|
@port19x Here is the current flow after the simplification. The slot parser is goneThe earlier slot/devalue explanation no longer applies. Miruro's HTML pages already contain the same data as plain JS objects ( Request and playback flowflowchart TD
Query["Search query"] --> Search["GET /search?q=... (HTML)"]
Search --> Items["items:[...]"]
Items --> ID["anilist:show:mal"]
ID --> Watch["GET /watch/show/x?ep=1 (HTML)"]
Watch --> Episodes["number: values -> episode list"]
Episodes --> Menu["Episode selection"]
Menu --> Tracks["tracks:[...] for selected episode"]
Tracks --> Pool["ssub, then sub (or dub)"]
Pool --> Servers["providers -> servers -> streams"]
Servers --> Master["HLS master with Referer/Origin"]
Master --> Variants["RESOLUTION variants"]
Variants --> Links["quality server > url"]
Links --> Choice["best or change_quality"]
Choice --> Player["mpv/IINA: Referer + Origin + forced HLS"]
Function boundaries
Current statePushed as |
Co-authored-by: GPT-6.1 Sol
|
Your last commit went in the wrong direction. |
|
Perhaps the most important exerpt of the guidelines for both you and your agent:
Right now at +527 -124 there is a zero percent chance I'll merge this |
|
Updated the flow comment above and pushed The provider now reads Miruro's HTML directly, lists all usable sources in the change-quality menu, and passes the required |
Resolve streams from Miruro's HTML pages, pass the Origin header these hosts require, force the HLS demuxer for extensionless playlists, and list every usable source in the change-quality menu.
14ffb76 to
92f65ba
Compare
port19x
left a comment
There was a problem hiding this comment.
Respect 💪
First glance impression: +150 -88 is much much better.
We'll see if we can maybe save another 10 lines or if not maybe make some details more elegant, but this is now already within the range of acceptable code.
It also reads closer to previous provider systems, just good old sed and no type 2 slot system.
miruro_media is a little long and a little complicated still, though I'm not sure how much of that is essential complexity modeling how the provider works and how much of it is incidental complexity, purely introduced by implementation.
The most immediate win I see is a bunch of variable="" initializations.
I understand this can be correct when resetting in a loop for example, but please double check which ones are actually just redundant because you have a true assignment at a later point with no risk of collision with a previous value.
In unrelated news I have a cheap android device on its way to play around with so, with some luck, I can do the initial android testing this weekend.
Co-authored-by: Hy4 flash Free <hy4-flash-free@opencode>
- carry referrer, origin, HLS, audio and subtitle URLs per source - forward audio and subtitle links to all players and downloads - use | delimiter so empty audio fields don't shift the subtitle URL - skip forced HLS demuxer when subs are present so they load - prefer a same-quality source with subs when the chosen one has none - simplify nth and history tab parsing
Switch the provider from HiAnime to Miruro.