Skip to content

feat: add ANI_CLI_FIRST_PLAY_FLAGS for first-play-only player flags - #1990

Closed
mhmdsamerdev wants to merge 1 commit into
pystardust:masterfrom
mhmdsamerdev:feat/first-play-flags
Closed

mhmdsamerdev wants to merge 1 commit into
pystardust:masterfrom
mhmdsamerdev:feat/first-play-flags

Conversation

@mhmdsamerdev

Copy link
Copy Markdown

Pull Request Template

Contributing guidelines · CI workflows

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

A start position in ANI_CLI_PLAYER_FLAGS also hit next/replay/previous. This adds ANI_CLI_FIRST_PLAY_FLAGS, applied to the first play only.

Which flags, players or platforms does this affect?
All players, because every branch already reads player_extra_flags.

Fixes #1989

Verification

ANI_CLI_PLAYER_FLAGS=--fs ANI_CLI_FIRST_PLAY_FLAGS=--start=605 ./ani-cli -S 1 -e 1 "blue lock", then choose next
The first episode gets --fs --start=605. The next episode (and replay and previous) gets --fs only.

Checklist

  • any anime playing
  • bumped version

  • next, prev, replay and select work
  • -c history and continue work
  • -d downloads work
  • -e (select episode) aka -r (range selection) works
  • -S select index works
  • -q quality works
  • -s syncplay works
  • -v vlc works
  • --dub and regular (sub) mode both work
  • --nextep-countdown countdown to next ep works

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

(these don't block a merge)

  • --skip ani-skip works
  • --no-detach no detach works
  • --exit-after-play auto exit after playing works

Copy Pasta

./ani-cli -V
./ani-cli -S 1 -e 1 -d flcl
./ani-cli -S 1 -e 1 -q worst -v flcl
./ani-cli -c -s --dub

@port19x

port19x commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Good patch for your own use, but this will not be merged into master

@port19x port19x closed this Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ANI_CLI_PLAYER_FLAGS start position also applies to "next", "previous" and "replay"

2 participants