Repository navigation
feat: add ANI_CLI_FIRST_PLAY_FLAGS for first-play-only player flags - #1990
Closed
mhmdsamerdev wants to merge 1 commit into
Closed
mhmdsamerdev wants to merge 1 commit into
mhmdsamerdev wants to merge 1 commit into
Conversation
Collaborator
|
Good patch for your own use, but this will not be merged into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Contributing guidelines · CI workflows
Type of change
Description
A start position in ANI_CLI_PLAYER_FLAGS also hit next/replay/previous. This adds ANI_CLI_FIRST_PLAY_FLAGS, applied to the first play only.
Which flags, players or platforms does this affect?
All players, because every branch already reads player_extra_flags.
Fixes #1989
Verification
ANI_CLI_PLAYER_FLAGS=--fs ANI_CLI_FIRST_PLAY_FLAGS=--start=605 ./ani-cli -S 1 -e 1 "blue lock", then choosenextThe first episode gets
--fs --start=605. The next episode (and replay and previous) gets--fsonly.Checklist
-chistory and continue work-ddownloads work-e(select episode) aka-r(range selection) works-Sselect index works-qquality works-ssyncplay works-vvlc works--duband regular (sub) mode both work--nextep-countdowncountdown to next ep works-hhelp info is up to dateAdditional Testcases
(these don't block a merge)
--skipani-skip works--no-detachno detach works--exit-after-playauto exit after playing worksCopy Pasta