Skip to content

fix: preserve default subtitle URLs - #1966

Closed
rvoroz wants to merge 8 commits into
pystardust:masterfrom
rvoroz:fix/subtitle-parser
Closed

rvoroz wants to merge 8 commits into
pystardust:masterfrom
rvoroz:fix/subtitle-parser

Conversation

@rvoroz

@rvoroz rvoroz commented Oct 12, 2026

Copy link
Copy Markdown

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

Fix subtitle URL extraction when subtitle labels contain brackets, ensuring ani-cli -d downloads the .vtt file correctly.

Related to #1932

Checklist

  • any anime playing
  • bumped version

  • next, prev, replay and select work
  • -c history and continue work
  • -d downloads work
  • -e (select episode) aka -r (range selection) works
  • -S select index works
  • -q quality works
  • -s syncplay works
  • -v vlc works
  • --dub and regular (sub) mode both work
  • --nextep-countdown countdown to next ep works

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

@port19x

port19x commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Does this fix the eminence 2 episode 2 issue?
Alternatively, is there any other anime I can test this with?
The change itself looks good

@port19x port19x linked an issue Oct 20, 2026 that may be closed by this pull request
@rorozco-rynoh

Copy link
Copy Markdown

I did not tested it with it that title but its working for several current season animes. Also i have this fix applied to my local script and is working fine so far.

@port19x port19x left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not fix the missing subtitles, as present in eminence 2 episode 2

@port19x

port19x commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator
Screenshot 2026-10-22 at 18 16 23

@rvoroz

rvoroz commented Oct 22, 2026

Copy link
Copy Markdown
Author

I checked The Eminence in Shadow Season 2, episode 2 (MAL 54595). The ZokoAnime response contains "subtitles":[] and "default_audio":null. Its master playlist only contains the 1080p video stream and no EXT-X-MEDIA entries. ani-cli therefore correctly prints an empty Subtitles: field. This appears to be a provider-side missing-subtitles case, not a parser or download bug.

Response from the provider

{ "src": "https://hls.dramahot.top/.../master.m3u8", "subtitles": [], "default_audio": null }

Master Playlist
#EXTM3U #EXT-X-VERSION:4 #EXT-X-STREAM-INF:BANDWIDTH=5300000,RESOLUTION=1920x1080 1080/index.m3u8

Also on the webpage does not show the subs

image

@port19x

port19x commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

Okay, that's certainly plausible. Can you give me any other test case of an anime that your PR fixes?

@rvoroz

rvoroz commented Oct 22, 2026

Copy link
Copy Markdown
Author

Resolved conflicts un merged from master

@rvoroz

rvoroz commented Oct 22, 2026

Copy link
Copy Markdown
Author

Test cases and related issues investigated:

  • Dark Summoner to Dekiteiru / I’m Dating a Dark Summoner — subtitles were correctly detected and downloaded after rerunning the episode.
  • The Eminence in Shadow Season 2, episode 2 — the source returned an empty subtitles array, so this is a provider-side issue rather than a parser issue.
  • Kyouran Reijou Nia Liston — investigated as another subtitle-related case.
  • Mahou Shoujo Ikusei Keikaku Restart — investigated as another subtitle-related case.

@port19x

port19x commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

All of these work on master 😬

@port19x port19x closed this Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some episodes don't have a subtitles.

3 participants