Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid-type message for creating header from dictionary #1334

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gtamazian
Copy link

The message for the type error when creating a SAM header from a dictionary misses type names. The following MWE causes the error by passing a dictionary instead of a list of dictionaries under the PG tag in the SAM header:

import pysam

header = {"PG": {"ID": "my-tool"}}
output = pysam.AlignmentFile("test.sam", "w", header=header)

The current invalid-type error message:

ValueError: invalid type for record %s: %s, expected %s

The fixed error message:

ValueError: invalid type for record PG: <class 'dict'>, expected <class 'collections.abc.Sequence'>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant