Automatically translate VariantRecord on write #1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These commented lines were added in kkchau@c30ead4 and kkchau@36eb1da but commented out. Not sure if there is still work that needs to be done (if so, I can close this PR), but seems to work after a couple of tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable auto-translation of VariantRecord headers on write when a different header is detected.
Current functionality does not check if headers match on write, potentially resulting in (silent and dangerous) reshuffling of fields, e.g. when header records are ordered differently. Uncomment the lines that detects header differences and translates the VariantRecord to the new header to be written.