remove tools/gitcount.ipynb

[jGaboardi]

• remove tools/gitcount.ipynb
• no longer used

[martinfleis]

Wouldn't it be useful to keep those two notebooks around?

[jGaboardi]

Yes, I suppose so. I'll move them into the notebooks/* directory for this PR unless there are better ideas.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.0%. Comparing base (0dfa4e9) to head (00c993c).
Report is 1 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #368   +/-   ##
=====================================
  Coverage   82.0%   82.0%           
=====================================
  Files         24      24           
  Lines       3489    3489           
=====================================
  Hits        2861    2861           
  Misses       628     628           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[martinfleis]

Aren't those pulled to the notebooks project and copied to docs? Should they?

[jGaboardi]

Aren't those pulled to the notebooks project

By "those" do you mean the tools/moran_* notebooks? Where do so see this happening?

copied to docs

docs/notebooks/ should probably be deleted. We are doing the same over in spopt but that happens only in the docs build action and should probably not be stored there in docs/notebooks/

[martinfleis]

I thought that the contents of notebooks folder is being pulled to https://pysal.org/notebooks/explore/esda/intro.html but that does not seem to be the case.

What I mean is that these two moran_ notebooks should not be in docs and while notebooks shall be copied to docs under the current system, they would become part of the docs if stored in notebooks.

[jGaboardi]

OK, so I'll just keep the tools/ directory and remove the gitcount.ipynb notebook. Then open an issue for discussion on what to do with the tools/moran_* notebooks.

[martinfleis]

Can you revert changes done to moran_* notebooks?

[jGaboardi]

I didn't make any changes. Didn't even open them. Weird....

[martinfleis]

As per diff, there are now copies in notebooks.

[jGaboardi]

Not sure what I'm doing wrong here. Tried reseting to HEAD and upstream/main, reverting previous commit but still showing that I am changing/pushing new version of the moran libraries.

Shall I simply close this PR and open another?

[jGaboardi]

OMG... must be early on Sunday morning... I am blind