Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove s3 file from annotations and use an observation array in… #28

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

feat: remove s3 file from annotations and use an observation array in… #28

wants to merge 24 commits into from

Conversation

Nastaliss
Copy link
Collaborator

…stead

@ghost
Copy link

ghost commented Jul 20, 2023

Nice of you to open a PR 🙏
When you're ready and want to get it reviewed, post a comment in this Pull Request with this message: /quack review

@frgfm
Copy link
Member

frgfm commented Sep 16, 2023

Hey there!

Quick question: instead of an array, don't you think we should have a string (JSON dump of the dict)?

@GHCamille GHCamille mentioned this pull request Sep 22, 2023
Open
@Nastaliss
Copy link
Collaborator Author

Hey there!

Quick question: instead of an array, don't you think we should have a string (JSON dump of the dict)?

I have no preference, if using a jsonb is closer to what's in other tables of the db then sure :)

@codecov Codecov
Copy link

codecov bot commented Apr 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.22%. Comparing base (ecafe68) to head (43e4a50).
Report is 7 commits behind head on main.

Files Patch % Lines
src/app/db/models.py 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   87.40%   88.22%   +0.81%     
==========================================
  Files          24       24              
  Lines         540      518      -22     
==========================================
- Hits          472      457      -15     
+ Misses         68       61       -7
Flag Coverage Δ
unittests 88.22% <95.00%> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

frgfm
frgfm reviewed May 24, 2024
View reviewed changes
Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests seem to fail with list not being hashable, would you mind checking? 🙏

Nastaliss and others added 6 commits July 1, 2024 14:17
@Nastaliss
chore: retrigger ci
62c4f9f
@dependabot @Nastaliss
chore(deps): Bump certifi from 2022.12.7 to 2023.7.22 (#29)
212cda3 
Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.12.7 to 2023.7.22.
- [Commits](certifi/python-certifi@2022.12.07...2023.07.22)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @Nastaliss
chore(deps): Bump gitpython from 3.1.31 to 3.1.34 (#31)
ee5f16e 
Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.31 to 3.1.34.
- [Release notes](https://github.com/gitpython-developers/GitPython/releases)
- [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES)
- [Commits](gitpython-developers/GitPython@3.1.31...3.1.34)

---
updated-dependencies:
- dependency-name: gitpython
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @Nastaliss
chore(deps): Bump gitpython from 3.1.34 to 3.1.35 (#32)
b746327 
Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.34 to 3.1.35.
- [Release notes](https://github.com/gitpython-developers/GitPython/releases)
- [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES)
- [Commits](gitpython-developers/GitPython@3.1.34...3.1.35)

---
updated-dependencies:
- dependency-name: gitpython
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@frgfm @Nastaliss
feat: Enables CORS using FastAPI middleware (#26)
64941bd 
* feat: Adds CORS middleware

* chore: Updates docker

* docs: Updates README
@dependabot @Nastaliss
chore(deps): Bump urllib3 from 1.26.15 to 1.26.17 (#33)
a6df74b 
Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.15 to 1.26.17.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.15...1.26.17)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dependabot bot added 2 commits July 1, 2024 23:45
@dependabot @Nastaliss
chore(deps): Bump gitpython from 3.1.35 to 3.1.37 (#34)
90d0326 
Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.35 to 3.1.37.
- [Release notes](https://github.com/gitpython-developers/GitPython/releases)
- [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES)
- [Commits](gitpython-developers/GitPython@3.1.35...3.1.37)

---
updated-dependencies:
- dependency-name: gitpython
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @Nastaliss
chore(deps): Bump urllib3 from 1.26.17 to 1.26.18 (#35)
ebc4104 
Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.17 to 1.26.18.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.17...1.26.18)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@github-actions github-actions bot added the topic: documentation Improvements or additions to documentation label Jul 1, 2024
@github-actions github-actions bot removed the topic: documentation Improvements or additions to documentation label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frgfm frgfm frgfm left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ext: client/tests ext: client ext: tests module: database route: annotations topic: docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nastaliss @frgfm