Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeout heartbeat #225

Merged
merged 1 commit into from
Jul 30, 2024
Merged

timeout heartbeat #225

merged 1 commit into from
Jul 30, 2024

Conversation

MateoLostanlen
Copy link
Member

From time to time, the api call is quite long (several seconds), which means we lose time in the execution loop, even though this is not mandatory.

@MateoLostanlen MateoLostanlen requested a review from a team July 30, 2024 13:13
@MateoLostanlen MateoLostanlen self-assigned this Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.53%. Comparing base (4742146) to head (ca8952b).
Report is 1 commits behind head on develop.

Files Patch % Lines
pyroengine/engine.py 64.28% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #225      +/-   ##
===========================================
- Coverage    88.84%   88.53%   -0.31%     
===========================================
  Files            6        6              
  Lines          529      541      +12     
===========================================
+ Hits           470      479       +9     
- Misses          59       62       +3     
Flag Coverage Δ
unittests 88.53% <64.28%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateoLostanlen MateoLostanlen merged commit a618731 into develop Jul 30, 2024
12 of 14 checks passed
@MateoLostanlen MateoLostanlen deleted the timeout_heartbeat branch July 30, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant