Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ncnn #217

Merged
merged 47 commits into from
Jul 16, 2024
Merged

Switch to ncnn #217

merged 47 commits into from
Jul 16, 2024

Conversation

MateoLostanlen
Copy link
Member

@MateoLostanlen MateoLostanlen commented Jul 15, 2024

In PR #210, we switched to a less performant model because processing time for a 1024 image was too long.

In this PR, we are returning to the more performant model because we managed to significantly reduce the processing time.

  1. We use the NCNN format instead of ONNX, which is more optimized for ARM processors. More information can be found here.
  2. We reorganized the core function with asynchronous functions. Now, we only wait for one camera to finish processing while analyzing the predictions from the previous capture.

I couldn't achieve the processing speed of Ultralytics without the library, so I suggest using it for now. However, it is a major dependency, so I will continue working on removing it.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 83.46457% with 21 lines in your changes missing coverage. Please review.

Project coverage is 90.21%. Comparing base (040552c) to head (e457622).

Files Patch % Lines
pyroengine/core.py 61.36% 17 Missing ⚠️
pyroengine/vision.py 96.49% 2 Missing ⚠️
pyroengine/engine.py 66.66% 1 Missing ⚠️
pyroengine/sensors.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #217      +/-   ##
===========================================
- Coverage    92.35%   90.21%   -2.14%     
===========================================
  Files            6        6              
  Lines          510      501       -9     
===========================================
- Hits           471      452      -19     
- Misses          39       49      +10     
Flag Coverage Δ
unittests 90.21% <83.46%> (-2.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateoLostanlen MateoLostanlen requested review from a team July 15, 2024 14:25
@MateoLostanlen MateoLostanlen merged commit 57e4b4c into develop Jul 16, 2024
11 of 14 checks passed
@MateoLostanlen MateoLostanlen deleted the switch_to_ncnn branch July 16, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant