Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility kludge to work with older packaging #1217

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix compatibility kludge to work with older packaging #1217

wants to merge 4 commits into from

Conversation

dnicolodi
Copy link
Contributor

Fixes #1216.

@dnicolodi dnicolodi force-pushed the fix-license-files-packaging-24 branch 3 times, most recently from 3680db0 to 3ea3455 Compare January 22, 2025 10:46
@dnicolodi
Copy link
Contributor Author

dnicolodi commented Jan 22, 2025 •
edited
Loading

The issue was not caught by the tests because they run with a more recent packaging. I can extend the CI matrix to cover a couple of versions of packaging but I would like to know if the maintainers think that this is a good idea before putting in the work...

sigmavirus24
sigmavirus24 previously requested changes Jan 22, 2025
View reviewed changes
Copy link
Member

@sigmavirus24 sigmavirus24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test coverage for this

@dnicolodi dnicolodi force-pushed the fix-license-files-packaging-24 branch 5 times, most recently from 71addd7 to fc6d0ce Compare January 22, 2025 13:51
@dnicolodi
Copy link
Contributor Author

@sigmavirus24 done. My tox-fu is very limited, thus I am not sure the way I am adding the versioned dependency is the best one. Let me know if you think there is a better way.

@dnicolodi
Copy link
Contributor Author

Ping?

@dnicolodi
Copy link
Contributor Author

Is there any maintainer that can have a look at this?

@dnicolodi dnicolodi force-pushed the fix-license-files-packaging-24 branch from fc6d0ce to baba88c Compare March 10, 2025 09:34
woodruffw
woodruffw approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dnicolodi, this approach LGTM. My tox-fu is also not the strongest, but this looks relatively idiomatic from other projects I've used it on.

@dnicolodi
Copy link
Contributor Author

dnicolodi commented Mar 10, 2025 •
edited
Loading

@woodruffw What is missing to merge this? @sigmavirus24 approval was conditional to the addition of tests and coverage in CI, which are there now.

@woodruffw
Copy link
Member

What is missing to merge this? @sigmavirus24 approval was conditional to the addition of tests and coverage in CI, which are there now.

Nothing on my end, I was just giving @sigmavirus24 a chance to re-review as well if he wants.

@sigmavirus24 sigmavirus24 dismissed their stale review March 10, 2025 22:20

No longer relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

@sigmavirus24 sigmavirus24 Awaiting requested review from sigmavirus24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dnicolodi @woodruffw @sigmavirus24