Drop Python 3.8 #1186
Open
Drop Python 3.8 #1186
+5
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
3.8
branch
from
96d0473 to
9290643
Compare
|
I have no strong opinion here, except that maybe we should follow the same support policy as pip? They support 3.8 still, I believe. |
|
I'm good with it, but let's wait until the dust has settled around other more pressing needs. |
|
We've always dropped with pip but there's nothing requiring that |
|
My idea was to update type checking, but there's no urgency in that. Close this PR? |
Nah, I think leaving it open is fine 🙂 |
DimitriPapadopoulos
force-pushed
the
3.8
branch
from
9290643 to
c40cd51
Compare
|
Pip seems to have dropped 3.8. So this seems fine now |
sigmavirus24
approved these changes
Mar 12, 2025
|
Just for tracking purposes: pypa/pip#13238 drops 3.8 support in (Not landed in a release yet, but I see no harm in landing on |
woodruffw
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it too early to drop Python 3.8?
https://devguide.python.org/versions/