Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename USE_EMOJI to PIPX_USE_EMOJI #1581

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

dkav
Copy link
Contributor

@dkav dkav commented Nov 28, 2024

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Rename environmental variable USE_EMOJI to PIPX_USE_EMOJI. Keeps support for USE_EMOJI. Fixes #1395.

Test plan

Tested by running

nox -- -k test_emojis
nox -- -k test_environment

Rename environmental variable USE_EMOJI to PIPX_USE_EMOJI. Keeps support for USE_EMOJI. Fixes #1395.
@huxuan
Copy link
Member

huxuan commented Nov 28, 2024

Good job! Thanks for the contribution!

@dukecat0 dukecat0 merged commit 31f2501 into pypa:main Nov 28, 2024
11 checks passed
@dkav dkav deleted the pipx_use_emoji branch November 28, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename USE_EMOJI to PIPX_USE_EMOJI
3 participants