Support username and password from keyring #1734
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funkyfuture
reviewed
Nov 7, 2024
There was a problem hiding this comment.
sorry that i missed this aspect back then. from looking at Github's web ui this lgtm. @ofek, would it be of help for you if i had a closer look with an IDE on this?
|
Yes please |
funkyfuture
reviewed
Nov 10, 2024
Comment on lines
+49
to
+59
| class MockKeyring: | ||
| @staticmethod | ||
| def get_credential(*_): | ||
| class Credential: | ||
| username = 'gat' | ||
|
|
||
| return Credential() | ||
|
|
||
| @staticmethod | ||
| def get_password(*_): | ||
| return 'guido' |
There was a problem hiding this comment.
i have no strong opinion on this, but it would imo make sense to
a) realize this as a test fixture that is automatically used on all tests in this module.
b) add the password attribute to the Credential dummy.
funkyfuture
reviewed
Nov 10, 2024
| @@ -72,6 +73,12 @@ def __get_username(self) -> str: | |||
| self.__username_was_read = True | |||
| return self._app.prompt(f"Username for '{self._repo_config['url']}' [__token__]") or '__token__' | |||
|
|
|||
| def _read_keyring(self) -> str | None: | |||
There was a problem hiding this comment.
this could also store the __password property as i'm assuming that using a username from this credentials source doesn't make sense with a password from another source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
this brings back the enhancement added with #713 that broke with f59508b.
Had minor problems getting the tests to run because https://hatch.pypa.io/latest/community/contributing/ is outdated, but https://github.com/pypa/hatch/blob/master/docs/community/contributing.md worked 👍.