Env version-source: add a fallback value #1710
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our build system sets the package version number via an environment variable. When developers are building locally (eg when doing a `uv sync`) the environment variable will not be set and the build fails. This is inconvenient and we'd rather it just fell back to some default value like 0.0.1.dev0+local)
|
Hi @ofek, is there anything I can do to help progress this PR? |
Without this patch, env var versioning is useless, it will not work for local development without hacks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our build system sets the package version number via an environment variable.
When developers are building locally (eg when doing a
uv sync) the environment variable will not be set and the build fails. This is inconvenient and we'd rather it just fell back to some default value like 0.0.1.dev0+local)