debug! #327 #328
Closed
debug! #327 #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah shucks, just noticed there's a different PR for this issue. See #327 (comment); I propose we pin the Python to a newer version than 3.9 (which is EOL this year), and we upgrade the setuptools version that is used as a build system. Maybe don't even hard-pin it, but use a |
This reverts commit 688a8c4.
|
No, I want reproducibility. If anything, it's underpinned. Pinning the OS will also ensure a static major version of Python, which is enough. |
They are pinned instead of using `-latest` in the interest of better reproducibility in the CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #327 has a failing CI. This is an attempt to verify whether it's failing on the default branch or the failure is related to the patch (the pins update).