Fix UnicodeAttribute and NumberAttribute serialization type checks #1286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- UnicodeAttribute now raises TypeError when given non-string values - NumberAttribute now raises TypeError when given non-numeric values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(attributes): enforce strict typing for UnicodeAttribute and NumberAttribute
UnicodeAttribute now enforces string typing at serialization.
Passing non-string values (e.g. int) raises TypeError instead of
failing only at AWS DynamoDB runtime. (Schema mismatch not detected locally when serializing Number/String attributes #1285)
NumberAttribute now enforces numeric typing at serialization.
Passing non-numeric values (e.g. bool, str, list, dict) raises
TypeError instead of being implicitly coerced or failing only at
AWS DynamoDB runtime. (Schema mismatch not detected locally when serializing Number/String attributes #1285)