Fix coords/dims guidance: mutable by default, shape never needed#41
Merged
Fix coords/dims guidance: mutable by default, shape never needed#41
Conversation
…er needed - Remove misleading mutable=True guidance (coords and pm.Data are mutable by default) - Add freeze_dims_and_data for when you want to freeze mutable coords/data - Replace "prefer dims, fall back to shape" with "always use dims, never shape" Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
|
that's not the syntax (there is no model.freeze_dims_and_data). Still mentioning NOT passing mutable=True, which is imo just a waste of context. |
Per Ricardo's feedback: - model.freeze_dims_and_data() does not exist; use the standalone function from pymc.model.transform.optimization instead - Remove 'Coords and Data are mutable by default' section -- mentioning mutable=True at all is a waste of context Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
Author
|
Fixed in b19585f:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Remove misleading
mutable=Trueguidance — coords andpm.Dataare mutable by default in PyMC, so the old subsection was a useless distraction\n- Addfreeze_dims_and_data— mention that this can be used to freeze existing mutable coords and data, which may simplify graphs or generate more efficient code\n- Replace "prefer dims, fall back to shape" with "always use dims, never shape" —shapeis never needed\n\nPer feedback from <@287659028241448961>.\n\n🤖 Generated with Claude Code