Skip to content

Conversation

@ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Oct 20, 2025

Closes #1577

We don't warn in any of our other backends, so it doesn't make sense to warn when using Python. This is specially annoying because we constant-fold with Python but didn't use to. This led to failures in the pymc-extras CI: pymc-devs/pymc-extras#597


📚 Documentation preview 📚: https://pytensor--1681.org.readthedocs.build/en/1681/

@ricardoV94
Copy link
Member Author

Failing test is the known unrelated bad boy

@jessegrabowski
Copy link
Member

Failing test is the known unrelated bad boy

I thought the previous failures were due to numpy < 2 but I guess it's a float32 thing now. Anyway not related to this PR so I don't care. Re-triggered the run to get a green dot, but feel free to not wait.

@ricardoV94
Copy link
Member Author

Failing test is the known unrelated bad boy

I thought the previous failures were due to numpy < 2 but I guess it's a float32 thing now. Anyway not related to this PR so I don't care. Re-triggered the run to get a green dot, but feel free to not wait.

I don't understand that test, there's not even anything stochastic in it. Can't be bothered to debug rn

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.62%. Comparing base (792bd04) to head (c578f51).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1681      +/-   ##
==========================================
- Coverage   81.64%   81.62%   -0.02%     
==========================================
  Files         242      242              
  Lines       53573    53545      -28     
  Branches     9453     9442      -11     
==========================================
- Hits        43737    43708      -29     
- Misses       7358     7361       +3     
+ Partials     2478     2476       -2     
Files with missing lines Coverage Δ
pytensor/tensor/elemwise.py 90.02% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94 ricardoV94 merged commit 9b522a8 into pymc-devs:main Oct 20, 2025
101 of 103 checks passed
@ricardoV94 ricardoV94 deleted the elemwise_warning branch October 20, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Suppress numpy warnings in PyTensor Elemwise perform

2 participants