Adding dot for xtensor #1450
Open
Adding dot for xtensor #1450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
reviewed
Jun 6, 2025
| @@ -151,3 +151,34 @@ def test_cast(): | |||
| yc64 = x.astype("complex64") | |||
| with pytest.raises(TypeError, match="Casting from complex to real is ambiguous"): | |||
| yc64.astype("float64") | |||
|
|
|||
|
|
|||
| def test_dot(): | |||
There was a problem hiding this comment.
Looks promising, but needs some tests calling dot with specific dims?
ricardoV94
reviewed
Jun 6, 2025
| y = as_xtensor(y) | ||
|
|
||
| # Validate dimensions if specified | ||
| if dims is not None: |
There was a problem hiding this comment.
These checks are better placed in make_node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dot operation to xtensor module
This PR adds support for the dot product operation in the xtensor module. The implementation includes:
New dot method
.dot()method toXTensorVariableinpytensor/xtensor/type.pyto provide a consistent interface for dot operations, similar to other math functions.Rewrite rule for dot
pytensor/xtensor/rewriting/math.pythat converts theXDotoperation to a tensor-based dot operation usingtensordot. This rule handles dimension alignment and contraction correctly.Import of math rewriting module
pytensor/xtensor/rewriting/__init__.pyto import the math rewriting module, ensuring that the dot rewrite rule is registered and available during the rewrite pass.Unit tests
test_dot()intests/xtensor/test_math.pyto verify the basic functionality of the dot operation, including matrix-matrix and matrix-vector dot products, proper dimension handling, and shape validation.These changes ensure that the xtensor module now supports dot operations, maintaining consistency with other math functions and enabling proper dimension handling for tensor contractions.
📚 Documentation preview 📚: https://pytensor--1450.org.readthedocs.build/en/1450/