Add support for sample_stats group in pymc.testing.mock_sample
#7887
+79
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7887 +/- ##
==========================================
- Coverage 92.94% 89.33% -3.61%
==========================================
Files 116 116
Lines 18851 18912 +61
==========================================
- Hits 17521 16895 -626
- Misses 1330 2017 +687
🚀 New features to boost your workflow:
|
|
Any updates needed for this? |
fonnesbeck
approved these changes
Oct 21, 2025
| from arviz import InferenceData | ||
| from numpy import random as nr | ||
| from numpy import testing as npt | ||
| from numpy.typing import NDArray |
There was a problem hiding this comment.
Maybe just use npt.NDArray as the code example in the docstring does?
There was a problem hiding this comment.
I see that numpy.testing as already imported as npt above. So I switched the docstring to use NDArray as well.
|
Getting some unrelated test failures now: https://github.com/pymc-devs/pymc/actions/runs/18698891077/job/53323157592 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows users to create sample_stats group in the mock sample helper
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7887.org.readthedocs.build/en/7887/