Skip to content

Consolidate progress bar speed logic #7801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

williambdean
Copy link
Contributor

@williambdean williambdean commented May 24, 2025

Description

Remove the duplicated logic for calculating speed and unit

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7801.org.readthedocs.build/en/7801/

@williambdean
Copy link
Contributor Author

what's up with the mypy. That is working locally for me. Maybe I need to update my versions

Copy link

codecov bot commented May 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.87%. Comparing base (c8d83ca) to head (095d448).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7801      +/-   ##
==========================================
+ Coverage   92.84%   92.87%   +0.02%     
==========================================
  Files         107      107              
  Lines       18380    18373       -7     
==========================================
- Hits        17065    17064       -1     
+ Misses       1315     1309       -6     
Files with missing lines Coverage Δ
pymc/util.py 83.00% <100.00%> (+1.18%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94
Copy link
Member

It's new numpy type hints stuff, I was putting some ignores in my PR to bump PyTensor that's still open

@williambdean
Copy link
Contributor Author

Alright. Let me know if I need to adjust anything in this PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused compute_draw_speed
2 participants