Fix MCMC non-deterministic seeding with Generators

[ricardoV94]

Closes #7612

Picked up the fix from #7540

---

📚 Documentation preview 📚: https://pymc--7637.org.readthedocs.build/en/7637/

[lucianopaz]

LGTM

[lucianopaz]

The failing test from the mac env actually happens because your second commit doesn't have all of the changes to pymc.step_methods.hmc.quadpotential that I had over in my PR

[ricardoV94]

The failing test from the mac env actually happens because your second commit doesn't have all of the changes to pymc.step_methods.hmc.quadpotential that I had over in my PR

So there was a broken intermediate commit?

[ricardoV94]

I guess this is missing: 2913e4a

[ricardoV94]

It's strange though, the test passes locally for me

[ricardoV94]

Ah must be the other mp_ctx that Mac defaults to. Should we be worried though that is not being passed?

[lucianopaz]

I guess this is missing: 2913e4a

Yes, it's that commit.

Ah must be the other mp_ctx that Mac defaults to. Should we be worried though that is not being passed?

It's not super important at the moment I think. The parallel sampling should still work because sampling state is not passed around there, but if you cherry-pick that other commit, then things should pass.

[ricardoV94]

It was the sequential sampling (on the CI we only have 1 core). I had to reorder so we handle the default values before we do the fix on sequential sampling

[lucianopaz]

LGTM

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (5d51953) to head (9dcd50a).
Report is 89 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7637      +/-   ##
==========================================
+ Coverage   92.83%   92.85%   +0.01%     
==========================================
  Files         106      106              
  Lines       17748    17771      +23     
==========================================
+ Hits        16477    16501      +24     
+ Misses       1271     1270       -1     

Files with missing lines	Coverage Δ
pymc/sampling/mcmc.py	86.18% <100.00%> (+0.05%)	⬆️
pymc/sampling/parallel.py	88.73% <100.00%> (ø)
pymc/step_methods/compound.py	97.56% <100.00%> (ø)
pymc/step_methods/hmc/quadpotential.py	84.69% <100.00%> (+0.06%)	⬆️
pymc/step_methods/state.py	96.55% <100.00%> (-1.57%)	⬇️
pymc/util.py	83.45% <100.00%> (+1.59%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.