-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Aesara to 2.7.5, aeppl to 0.0.32, update tests for aeppl #5955
Conversation
Waiting on conda-forge/aeppl-feedstock#35 or autotick-bot |
Codecov Report
@@ Coverage Diff @@
## main #5955 +/- ##
==========================================
- Coverage 89.54% 89.42% -0.13%
==========================================
Files 73 73
Lines 13273 13292 +19
==========================================
+ Hits 11885 11886 +1
- Misses 1388 1406 +18
|
The test expects a KeyError to be raised, but the behavior was modified in aesara-devs/aeppl#151. |
@maresb Want to fix that here? Sounds like a simple one. |
@twiecki I'm stuck because I'm confused what is the intention of the relevant test. I haven't ever used aeppl before, so I'm unfortunately missing context. In the first I was wondering if it made sense in the first case to add Any insight into what is the desired behavior here? Ping @ricardoV94 |
We were relying on the fact that aeppl would fail with |
This adapts to the change in behavior introduced in aesara-devs/aeppl#151.
@@ -5,8 +5,8 @@ channels: | |||
- defaults | |||
dependencies: | |||
# Base dependencies | |||
- aeppl=0.0.31 | |||
- aesara=2.7.4 | |||
- aeppl=0.0.32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some other file, either pre-commit or mypy something that specifies aesara/aeppl versions that have to be updated as well.
Checking the last commit where these dependencies were changed should show it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Last time we actually missed bumping Aesara in this location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I need to squash this last commit with my previous "Bump Aesara" and "Bump aeppl" commits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just squash-merge once we get greens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need, if you don't mind we squashing all the commits when merging. Otherwise you can.
We are less strict about this here than in Aesara for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash merge sounds great! 😅
All green! Ready to squash merge? 🚀 |
As soon as we get a release on PyPI I can generate the new Conda-Forge build, and then as long as there are no unexpected issues, this whole Conda recipe revamp will be complete. 😄 |
What is this PR about?
This is in preparation for a new version number of PyMC in order to delineate a point in time after the
pymc-base
Conda-Forge package was produced.NOTE: This relies on the not-yet-existent v0.0.32 release of
aeppl
.For Aesara and aeppl I bumped the version numbers in
conda-envs/*.yml
andrequirements*.txt
.For PyMC I bumped the version number in
pymc/__init__.py
.Checklist
Major / Breaking Changes
Bugfixes / New features
Docs / Maintenance