-
Notifications
You must be signed in to change notification settings - Fork 281
Add underflow discussion to HSGP-Basic #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ands which raise warnings
sync with fork from previous status.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thanks @Armatron44 ! I'll review ASAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @Armatron44 , thanks a lot! I left a few comments in ReviewNB, and as an overall ask: can we make this into an admonition block (see the style guide?
With a title like "Click if you get this XX issue". This is a very niche and technical issue, and I'm afraid having it displayed by default in the notebook will break the flow, especially as it's a beginner NB. Does this make sense to you?
View / edit / reply to this conversation on ReviewNB AlexAndorra commented on 2025-08-15T20:57:33Z Line #1. m52_L = m52_c * 50 # c * s Maybe just comment quickly on why s = 50 |
View / edit / reply to this conversation on ReviewNB AlexAndorra commented on 2025-08-15T20:57:34Z Line #14. # check non have underflowed to zero. Typo: non --> none |
View / edit / reply to this conversation on ReviewNB AlexAndorra commented on 2025-08-15T20:57:34Z Line #18. ) # this will not pass assertion. Maybe add an assertion error message? So that it displays better when failing |
View / edit / reply to this conversation on ReviewNB AlexAndorra commented on 2025-08-15T20:57:35Z Typo: "as you need a m large to cover small lengthscales" --> "as you need an m large enough to cover small lengthscales" |
Thanks @AlexAndorra for the comments and suggestions. I agree it hinders the flow of an introductory notebook so will try the admonition block as suggested. I've not much time this week so may have to leave this until next week to address. |
Hi all,
Added a section to address underflow in HSGPs as discussed here pymc-devs/pymc#7881. There's also a typo fix in the markdown cell that discusses m and c for
matern52
.Helpful links
📚 Documentation preview 📚: https://pymc-examples--803.org.readthedocs.build/en/803/