Changes for more diesel machines #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LordIdra
commented
Dec 15, 2025
LordIdra
commented
- Adds persistent data types for Duration and ProgressItem
- Progress item is now held and persisted by PylonProcessor and PylonRecipeProcessor
- Add cycles per second unit
- Some other small utils
OhmV-IR
requested changes
Dec 21, 2025
Contributor
OhmV-IR
left a comment
OhmV-IR
left a comment
There was a problem hiding this comment.
one cw comment and a design comment
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/datatypes/DurationPersistentDataType.kt
Show resolved
Hide resolved
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/util/gui/ProgressItem.kt
Show resolved
Hide resolved
OhmV-IR
approved these changes
Dec 23, 2025
Contributor
OhmV-IR
left a comment
OhmV-IR
left a comment
There was a problem hiding this comment.
LGTM CW (can't really IG test this one)
Seggan
approved these changes
Dec 26, 2025
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/util/PylonUtils.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.