-
Notifications
You must be signed in to change notification settings - Fork 9
PylonTickableEntity #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
PylonTickableEntity #483
Conversation
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/entity/base/PylonTickableEntity.kt
Outdated
Show resolved
Hide resolved
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/entity/base/PylonTickableEntity.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Seggan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few things missing here - I would suggest including the following in this PR, but if you don't want to do them in this PR just make sure open issues for them so we can keep track:
- Needs async ticking option as we have for blocks
- Needs error handling (we have error handling set up for other entity interfaces)
- Currently you're using a getter for
tickDelay, but the convention with these sorts of interface variables is to usesetTickIntervalandsetAsyncand so on. The reason for this is to avoid having loads of getters for trivial properties which became quite a problem especially w/ the fluid stuff. It should hopefully be fairly straightforward as you can replicate what ticking blocks do.
(also docs :P - you can just do something similar to the block tickers for this)
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/entity/base/PylonTickableEntity.kt
Outdated
Show resolved
Hide resolved
LordIdra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing but otherwise I'm happy
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/entity/EntityStorage.kt
Outdated
Show resolved
Hide resolved
Seggan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than Idra comments LGTM
Fixes #456