[ref:random-stuff] Add smelting #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordIdra
requested changes
Jun 29, 2025
Contributor
LordIdra
left a comment
LordIdra
left a comment
There was a problem hiding this comment.
Have not reviewed in a great deal of detail for obvious reasons. But the logic overall looks good to me. I have tested ingame and just a few suggestions
- Have contents lore be 'empty' if the smeltery contains nothing (really tiny thing)
- Smeltery appears to finish burning its current fuel after being turned off but temperature does not go up. I'd suggest we just stop the burning if the smeltery is turned off.
- Smeltery should probably accept fluids while turned off. Not accepting them is counterintuitive and has caught me off guard like 3 times so far
- Would be nice to see in the casting UI how much fluid will be used to cast the item
- Whatever the hell's going on here:
Otherwise this is pretty fucking cool. Especially the text rendering stuff. It feels complicated and mildly annoying enough to be interesting and actually motivate you to automate it, but not excessively so. Hopefully it's not too bad for performance (maybe some tweaking will be needed) but we can cross that bridge later.
src/main/java/io/github/pylonmc/pylon/base/items/multiblocks/smelting/CastRecipe.java
Show resolved
Hide resolved
src/main/java/io/github/pylonmc/pylon/base/items/multiblocks/smelting/SmelteryCaster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/pylonmc/pylon/base/items/multiblocks/smelting/SmelteryCaster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/pylonmc/pylon/base/items/multiblocks/smelting/SmelteryController.java
Show resolved
Hide resolved
src/main/java/io/github/pylonmc/pylon/base/items/multiblocks/MixingPot.java
Show resolved
Hide resolved
Member
Author
Yeah I am aware, made a core issue to fix in another PR cause it's non trivial and would just extend this PR |
LordIdra
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MEGA PR WITH UNRELATED CHANGES TIME