Fluid controllers

[Intybyte]

• Fixes Fluid limiter #495
• Fixes Fluid accumulator #494

Progress:

• Fluid Limiter code
• Fluid Limiter recipe
• Fluid Limiter name, lore and translatables

• Fluid Accumulator code
• Fluid Accumulator recipe
• Fluid Accumulator name, lore and translatables

• Translatables for new gui

Most of the display entities were always done by idra, so gonna delegate that thing to him, maybe in another PR

[Intybyte]

Forgot it had to wait till idra changed some fluid code, mb

[LordIdra]

Ok, you should be able to update this now since the fluid valve changes are in master. Let me know if you need any help or context on this. I am also happy to make the relevant changes if you prefer just lmk

[LordIdra]

2 things rq

1 - this can be removed in both

Preconditions.checkState(context instanceof BlockCreateContext.PlayerPlace, "Fluid filter can only be placed by a player");
        Player player = ((BlockCreateContext.PlayerPlace) context).getPlayer();

2 - this should be yeeted and just replaced with a 1000 mb buffer

// a bit of a hack - treat capacity as effectively infinite and override
        // fluidAmountRequested to control how much fluid comes in
        setCapacity(1.0e9);

[LordIdra]

Some more stuff

[LordIdra]

Should use PylonGuiBlock here

[Intybyte]

no because it doesn't allow me to add close/open handlers

[LordIdra]

You won't need them after swapping to FluidThresholdButton as I mentioned in my next comment

[LordIdra]

I would remove this, rebase off my latest PR (even-more-cargo-block), and do what I did with FluidThresholdButton in CargoFluidAccumulator. It's really simple and you can basically just copy paste it. It's a lot more convenient to just have 1 button with 4 controls (and maintains consistency)

[LordIdra]

Should use PylonGuiBlock

[Intybyte]

same reason as above