[ref:vaan/feature/procedural-crafting] Procedural Crafting #476

Intybyte · 2025-12-05T12:01:25Z

Progress:

Recipe Type
Make Item and Block
Item checks and processing logic
Display framework and progress

Stuff to decide:

Lore and maybe change item name?
Recipe
Messages or particles or other

Example usage

pylonbase:iron_screw:
  ingredients:
    pattern:
      - "I  "
      - "   "
      - "   "
    key:
      I: pylonbase:iron_sheet
  results:
    - minecraft:stick: 8
  steps:
    - tool: minecraft:clock
      add_displays:
        - name: "base"
          material: light_gray_concrete
          position: [0, 0]
          scale: [1.0, 1.0]
    - tool: minecraft:iron_axe
      uses: 7
      remove_displays: ["base"]
      add_displays:
        - name: "screw1"
          material: light_gray_concrete
          position: [0.1, 0]
          scale: [0.08, 0.1]
          mirror_x: true
        - name: "screw2"
          material: light_gray_concrete
          position: [0.2, 0]
          scale: [0.08, 0.1]
          mirror_x: true
        - name: "screw3"
          material: light_gray_concrete
          position: [0.3, 0]
          scale: [0.08, 0.1]
          mirror_x: true
        - name: "screw4"
          material: light_gray_concrete
          position: [0.4, 0]
          scale: [0.08, 0.1]
          mirror_x: true
    - tool: pylonbase:iron_hammer
      uses: 8

Intybyte · 2025-12-13T14:54:01Z

I have no idea what to put in the Lore

Intybyte · 2025-12-13T20:24:09Z

depends on pylonmc/pylon-core#522

Intybyte · 2025-12-14T22:19:48Z

I feel like this is ready for review even if not fully complete, also from last testing it seems that on shutdown the entities aren't loaded back up properly, i have no idea what is causing it and it would be helpful if you guys had any idea

LordIdra

Some general comments

Instead of sending messages, we should give some visual indication. maybe particles of some kind? The only thing is they'd have to be per stage which is annoying
Hammer sends 'cannot be used on this block' message - I assume this can be fixed later when PylonWorkbenchTool (or whatever its called) interface is introduced.
Displays need to be yeeted when the craft is finished

I would suggest making all the recipes shapeless tbh. It feels more intuitive to me (there's no logical reason why the iron screws recipe should have to be in the top left at all - or even why there would ever be a fixed arrangement given it's a workbench where you're moving stuff around as you make it). It'll make automation 10x easier to implement as well. (It'll also make the code simpler)

I would suggest eventually replacing the workbench with a table display model + structure void. The working area feels awkwardly large, I think it only needs to be like 0.7x0.7

Instead of displaying the next step in the GUI, I would suggest using display entities instead so it's more immersive. Idea for this: above the model add the following (from top to bottom):

Text display showing number of remaining uses
Item display with the item that needs to be used next
Small text display with the name of the item that needs to be used next
(All should be billboards so they face the player all the time)

I think this worbench should only have an input section in the UI, and the output should just be dropped in world. Then, we could introduce some kind of 'Blueprint Workbench' which holds a specific workbench recipe and has both an input/output. This would make full automation feasible. And also it would be consistent with other early-game machines as all of them drop stuff in-world

Btw you're probably going to need some kind of Z-index for displays because some might end up overlapping each other

have only very lightly skimmed the code since I imagine a lot will still change

src/main/java/io/github/pylonmc/pylon/base/content/machines/simple/AssemblyTable.java

Intybyte · 2025-12-15T08:36:42Z

Some general comments
* Instead of sending messages, we should give some visual indication. maybe particles of some kind? The only thing is they'd have to be per stage which is annoying

* Hammer sends 'cannot be used on this block' message - I assume this can be fixed later when PylonWorkbenchTool (or whatever its called) interface is introduced.

* Displays need to be yeeted when the craft is finished
I would suggest making all the recipes shapeless tbh. It feels more intuitive to me (there's no logical reason why the iron screws recipe should have to be in the top left at all - or even why there would ever be a fixed arrangement given it's a workbench where you're moving stuff around as you make it). It'll make automation 10x easier to implement as well. (It'll also make the code simpler)

I would suggest eventually replacing the workbench with a table display model + structure void. The working area feels awkwardly large, I think it only needs to be like 0.7x0.7

Instead of displaying the next step in the GUI, I would suggest using display entities instead so it's more immersive. Idea for this: above the model add the following (from top to bottom):
* Text display showing number of remaining uses

* Item display with the item that needs to be used next

* Small text display with the name of the item that needs to be used next
  (All should be billboards so they face the player all the time)
I think this worbench should only have an input section in the UI, and the output should just be dropped in world. Then, we could introduce some kind of 'Blueprint Workbench' which holds a specific workbench recipe and has both an input/output. This would make full automation feasible. And also it would be consistent with other early-game machines as all of them drop stuff in-world

Btw you're probably going to need some kind of Z-index for displays because some might end up overlapping each other

have only very lightly skimmed the code since I imagine a lot will still change

at this point instead of nuking basically 90% of this PR should i just make he blueprint workbench instead of the assembly table? after all that is what I interpreted this as

LordIdra · 2025-12-15T08:48:12Z

I think we should have both, worktable for manual, blueprint for automatic.

Intybyte · 2025-12-15T08:52:46Z

I think we should have both, worktable for manual, blueprint for automatic.

I didn't say to drop one of them, just to focus on only one of the for the scope of this PR, and the blueprint seems to be the most fitting atm

Intybyte · 2025-12-15T08:53:51Z

So i don't have to nuke the whole simplified recipe system i made, 2 inventories and their handlers, and more stuff, also there is still the bug that on restart the display mess up for some reason that i can't figure out the cause

LordIdra · 2025-12-15T10:06:30Z

Ah ok. Sure that seems fine

Intybyte · 2025-12-15T10:21:24Z

Ok renamed everything, but before going on into using entities for everything, I want someone to help me find and fix the bug that causes the entities spawned at restart to desync with the table

Intybyte · 2025-12-15T10:21:56Z

Also extracting some common stuff between the assembly table and blueprint workbench into a separate class

Intybyte · 2025-12-16T10:12:33Z

* Instead of sending messages, we should give some visual indication. maybe particles of some kind? The only thing is they'd have to be per stage which is annoying

It is going to be annoying regardless, i don't want it to mess with action bars because most plugins already use it, nor waila, so message is the best thing, i don't want to mute my pc every time i am crafting a recipe with tons of steps either, message is the best thing imo, or maybe a low volume sound if you prefer, or we can have both, one of my ideas was adding an optional sound per step after all

* Hammer sends 'cannot be used on this block' message - I assume this can be fixed later when PylonWorkbenchTool (or whatever its called) interface is introduced.

Yeah i have no idea how we are going to do that though, what was your idea for PylonWorkbenchTool

* Displays need to be yeeted when the craft is finished

It was a bug, has been fixed

I would suggest eventually replacing the workbench with a table display model + structure void. The working area feels awkwardly large, I think it only needs to be like 0.7x0.7

Is this the same for the blueprint table? if you want you can commit how you want it to look like directly tbh

Instead of displaying the next step in the GUI, I would suggest using display entities instead so it's more immersive. Idea for this: above the model add the following (from top to bottom):

Added, it always faces north regardless which is a bit annoying, the display in the GUI is staying because tbh, it is convenient to not spin around the table sometimes, also it causes no harm keeping it

Once this is done i can start work on the assembly table

LordIdra · 2025-12-16T10:38:40Z

It is going to be annoying regardless, i don't want it to mess with action bars because most plugins already use it, nor waila, so message is the best thing, i don't want to mute my pc every time i am crafting a recipe with tons of steps either, message is the best thing imo, or maybe a low volume sound if you prefer, or we can have both, one of my ideas was adding an optional sound per step after all

Why not particles as suggested? Message just seems really jank and will be extremely annoying in a multiplayer environment where you also want to see what other players are typing.

Yeah i have no idea how we are going to do that though, what was your idea for PylonWorkbenchTool

See the last message in the procedural crafting thread

Is this the same for the blueprint table? if you want you can commit how you want it to look like directly tbh

I think yes blueprint table should also have a smaller area as it feels weird to have it this big imo. If you don't want to do it then I can do it in another pr, but tbh it's not really hard just fiddly and I don't have a clear picture for how it should look either.

Added, it always faces north regardless which is a bit annoying, the display in the GUI is staying because tbh, it is convenient to not spin around the table sometimes, also it causes no harm keeping it

This is why I said '(All should be billboards so they face the player all the time)'. Use the billboard setting.

Intybyte · 2025-12-16T11:43:22Z

Yeah let's make the models in other PRs, didn't know what billboard was, will look for the other stuff later

Seggan

Overall a good job, some critiques tho:

I would prefer the workbench to not have a GUI at all, maybe place the inputs on top?
Can I make the displays 3d?
Item displays are a bit too high, all 3 don't fit on my screen
Make the item displays only display to the players within n blocks (theres a method for that I think) so we won't expose secret bases
I can't figure out how blueprint workbench works
How does one do stuff like add a "sonic screwdriver" manual tool and then also have an "automatic sonic screwdriver"? By which I mean what methods do I call to perform a specific step in-code?

Seggan · 2025-12-30T00:33:31Z

src/main/java/io/github/pylonmc/pylon/base/content/machines/simple/AssemblyTable.java

+        );
+
+        List<ItemStack> requiredItems = new ArrayList<>(currentRecipe.ingredients());
+        ItemStack[] unsafeItems = craftInventory.getUnsafeItems();


Shouldnt use unsafeItems imo but thats a nit

Seggan · 2025-12-30T00:49:24Z

src/main/java/io/github/pylonmc/pylon/base/content/machines/simple/AssemblyTable.java

+        return builder.build();
+    }
+
+    public void handleGui(PlayerInteractEvent event) {


...why do you have a custom gui handler?

Seggan · 2025-12-30T01:04:50Z

src/main/java/io/github/pylonmc/pylon/base/recipes/intermediate/RecipeFormation.java

+    }
+
+    public RecipeChoice getChoice(int x, int y) {
+        var character = this.rows[y].charAt(x);


dude was too lazy to type one extra letter

Seggan · 2025-12-30T02:58:10Z

src/main/java/io/github/pylonmc/pylon/base/recipes/intermediate/Step.java

+        }
+    }
+
+    public interface StepsHolder {


Why have a separate holder class? seems to me like overcomplicating the API

It is used in ProceduralCraftingTable abstract class

LordIdra

Have you decided to go ahead with the assembly table then? I see that the class exists and has code that seems to progress the recipe. If not I'd suggest maybe just remove it for now to simplify things.

LordIdra · 2026-01-02T02:03:12Z

src/main/java/io/github/pylonmc/pylon/base/content/machines/simple/BlueprintWorkbench.java

+            stack = current.asStack(current.uses() - currentProgress.getUsedAmount());
+        }
+
+        this.stepDisplay.setItem(UpdateReason.SUPPRESSED, 0, stack);


Why is stepDisplay a virtual inventory? (Actually - maybe you don't know about invui's items? Have a read of the invui docs - https://docs.xenondevs.xyz/invui/ - using a custom item is a much nicer approach than having a virtual inventory)

LordIdra · 2026-01-02T02:05:36Z