[ref:vaan/feature/crucible] Crucible #449

Intybyte · 2025-11-14T19:47:17Z

Fixes #299

Seggan · 2025-11-14T19:50:34Z

The linked issue should be accomplished by allowing melting rocks into a smeltery imo

Seggan · 2025-11-14T19:50:42Z

Instead of adding a whole new machine

Intybyte · 2025-11-14T20:01:14Z

The linked issue should be accomplished by allowing melting rocks into a smeltery imo

That feels like shooting ducks with a cannon tho

Seggan · 2025-11-15T17:49:28Z

That feels like shooting ducks with a cannon tho

~~Ain't no one gonna stop me~~

src/main/resources/recipes/pylonbase/crucible.yml

LordIdra

This is almost identical to the mixing pot as it stands.

I would suggest instead to do what 'modded' crucibles do, where items that get thrown in are consumed (one by one) and then slowly melted. So you throw cobblestone in, and over 25 seconds, 4 mb of lava are added per second. Then, it's ready to consume the next cobblestone you throw in. (And also produces smoke gradually as it goes).

This makes balancing much easier and differentiates this enough to make it worth having alongside the mixing pot

Intybyte · 2025-11-20T16:52:01Z

This is almost identical to the mixing pot as it stands.

I would suggest instead to do what 'modded' crucibles do, where items that get thrown in are consumed (one by one) and then slowly melted. So you throw cobblestone in, and over 25 seconds, 4 mb of lava are added per second. Then, it's ready to consume the next cobblestone you throw in. (And also produces smoke gradually as it goes).

This makes balancing much easier and differentiates this enough to make it worth having alongside the mixing pot

Ok did something very similar to modded, instead of having it tick every second and add it gradually (which with many crucibles it might be unnecessarily performance intensive), I made it melt a block every X ticks, just like modded crucibles depending on the heat source below, it will change the melting speed

LordIdra · 2025-11-25T00:47:46Z

Not building with latest core (do I need to use a specific branch?)

Intybyte · 2025-11-26T21:05:08Z

Not building with latest core (do I need to use a specific branch?)

Didn't push to core, mb

Intybyte · 2025-11-26T21:09:36Z

Requires pylonmc/pylon-core#512

Seggan · 2025-12-05T17:22:21Z

(changed name so itll compile)

Intybyte · 2025-12-05T20:24:15Z

I think it is done?

Intybyte · 2025-12-12T15:04:11Z

Requires pylonmc/pylon-core#521

LordIdra

Just a couple more small things I noticed.

Another thing, the ticking rate seems to have gone up a LOT, like it chomps up cobblestone like crazy now. Assuming this isn't intended?

src/main/resources/lang/en.yml

src/main/java/io/github/pylonmc/pylon/base/content/machines/simple/Crucible.java

src/main/java/io/github/pylonmc/pylon/base/recipes/CrucibleRecipe.java

src/main/java/io/github/pylonmc/pylon/base/content/machines/simple/Crucible.java

Intybyte · 2025-12-14T12:53:02Z

Just a couple more small things I noticed.

Another thing, the ticking rate seems to have gone up a LOT, like it chomps up cobblestone like crazy now. Assuming this isn't intended?

yes, it depends on the block below, if you use lava it is supposed to be a LOT faster, if you use a torch, it should have same behaviour as before (minimum speed)

Seggan

Played around with it ingame, ngl I would prefer you throwing in items instead of right clicking the crucible. Barring that, at least a way to get the items out pls?

src/main/java/io/github/pylonmc/pylon/base/recipes/CrucibleRecipe.java

src/main/java/io/github/pylonmc/pylon/base/util/BaseUtils.java

src/main/java/io/github/pylonmc/pylon/base/PylonBase.java

src/main/resources/recipes/pylonbase/crucible.yml

LordIdra

You should be able to put in items when it's not heated. Right now you can't. I think making this not a multiblock will fix that.

src/main/java/io/github/pylonmc/pylon/base/content/machines/simple/Crucible.java

src/main/java/io/github/pylonmc/pylon/base/util/BaseUtils.java

LordIdra · 2025-12-21T20:59:31Z

src/main/java/io/github/pylonmc/pylon/base/util/BaseUtils.java

        animate(display, 0, duration, matrix);
    }
+
+    public static @NotNull ItemStack makeItem(@NotNull NamespacedKey key) {


I feel like I might have mentioned this already, but this seems like a common enough thing that it should be a core util. In fact, don't we already do something similar when deserializing recipe inputs? Presumably the logic from there could just be extracted

ItemTypeWrapper is indeed similar, however there is no fallback behaviour like in this case, do you still want me to extract it to a core util?

I think it would be a good idea yes - this seems like a relatively common thing that addons might want to do

Maybe in the future, this already depends on the Dynamic Tick Interval, so we can make and fix the issue after this is merged, or yo want Dynamic Tick Interval to handle this too?

Uhhh up to you. I think adding it to the dynamic tick interval PR is fine.

src/main/resources/lang/en.yml

src/main/resources/recipes/minecraft/crafting_shaped.yml

src/main/java/io/github/pylonmc/pylon/base/content/machines/simple/Crucible.java

LordIdra

The particles still look really awkward IMO but I think this will be easier when/if we change the mixing pot and crucible to display the liquid inside of it better so I am happy to leave it for now

Nice work on this. Just a few small things but I will leave it be and merge after that. Hope the reviews haven't been too much lol

src/main/java/io/github/pylonmc/pylon/base/content/machines/simple/Crucible.java

src/main/java/io/github/pylonmc/pylon/base/recipes/CrucibleRecipe.java

# Conflicts: # src/main/java/io/github/pylonmc/pylon/base/BaseItems.java # src/main/java/io/github/pylonmc/pylon/base/BaseRecipes.java # src/main/resources/lang/en.yml # src/main/resources/recipes/minecraft/crafting_shaped.yml

Intybyte added 5 commits November 14, 2025 19:26

Add crucible recipe and block

4b12c07

Add names and fancy stuff

f2110c1

Use RecipeInput.Item instead

53d9886

Add recipes

b1211ab

Add crucible's recipe

bd52e22

Seggan approved these changes Nov 18, 2025

View reviewed changes

src/main/resources/recipes/pylonbase/crucible.yml Show resolved Hide resolved

LordIdra requested changes Nov 19, 2025

View reviewed changes

Intybyte marked this pull request as draft November 19, 2025 19:55

Make Crucible a tickable that works with one item at a time

1e9ed7a

Intybyte marked this pull request as ready for review November 20, 2025 16:40

Intybyte added 6 commits November 20, 2025 17:57

Add a bunch more torches

eda0063

cleanup

a6a5212

No need to recreate it everytime

2b18932

Cleanup constructor

cbcf701

Extract method

5e8744b

Properly display heat sources

31db01d

Intybyte marked this pull request as draft November 27, 2025 17:30

Heatable registry and better handling

64b93b2

Seggan changed the title ~~Crucible~~ [ref:vaan/feature/crucible] Crucible Dec 5, 2025

Intybyte marked this pull request as ready for review December 5, 2025 20:24

LordIdra reviewed Dec 14, 2025

View reviewed changes

src/main/resources/lang/en.yml Outdated Show resolved Hide resolved

src/main/java/io/github/pylonmc/pylon/base/content/machines/simple/Crucible.java Outdated Show resolved Hide resolved

src/main/java/io/github/pylonmc/pylon/base/recipes/CrucibleRecipe.java Outdated Show resolved Hide resolved

LordIdra reviewed Dec 14, 2025

View reviewed changes

src/main/java/io/github/pylonmc/pylon/base/content/machines/simple/Crucible.java Outdated Show resolved Hide resolved

Intybyte added 2 commits December 14, 2025 13:49

Address review

c01b11b

Use PylonUtils#setNullable

4cf13d4

Intybyte added 2 commits December 20, 2025 13:15

Nuke old stack system

28108bc

Show stored items

a55b843

Seggan reviewed Dec 20, 2025

View reviewed changes

Optimize imports

62ab108

LordIdra requested changes Dec 21, 2025

View reviewed changes

Intybyte added 9 commits December 30, 2025 10:54

Nuke heat manager

7ef488f

Naming convention

5b6c5ae

Move method

e2e8b97

Remove multiblock

dc595f5

Inline getBelow

09582df

Update lore

2ccabfb

Use Refractory Brick

a813370

Swap particles

97e8c1a

Rename to itemFromKey

d446068

LordIdra requested changes Dec 30, 2025

View reviewed changes

Intybyte added 5 commits December 30, 2025 15:23

Floating point magic

09e8569

More error info

c5d9729

Merge branch 'master' into vaan/feature/crucible

eb020f3

# Conflicts: # src/main/java/io/github/pylonmc/pylon/base/BaseItems.java # src/main/java/io/github/pylonmc/pylon/base/BaseRecipes.java # src/main/resources/lang/en.yml # src/main/resources/recipes/minecraft/crafting_shaped.yml

Fix merge

079ee8c

Address review

b9843ff

Intybyte changed the title ~~[ref:vaan/feature/crucible] Crucible~~ [ref:vaan/fix/dynamic-tick-interval] Crucible Dec 30, 2025

Intybyte added 2 commits December 30, 2025 17:51

Merge branch 'master' into vaan/feature/crucible

87fbc00

Extract to PylonUtils

dfb2fbd

Intybyte changed the title ~~[ref:vaan/fix/dynamic-tick-interval] Crucible~~ [ref:vaan/feature/crucible] Crucible Dec 30, 2025

[ref:vaan/feature/crucible] Crucible #449

Are you sure you want to change the base?

[ref:vaan/feature/crucible] Crucible #449

Uh oh!

Conversation

Intybyte commented Nov 14, 2025

Uh oh!

Seggan commented Nov 14, 2025

Uh oh!

Seggan commented Nov 14, 2025

Uh oh!

Intybyte commented Nov 14, 2025

Uh oh!

Seggan commented Nov 15, 2025

Uh oh!

Uh oh!

LordIdra left a comment

Choose a reason for hiding this comment

Uh oh!

Intybyte commented Nov 20, 2025

Uh oh!

LordIdra commented Nov 25, 2025

Uh oh!

Intybyte commented Nov 26, 2025

Uh oh!

Intybyte commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Seggan commented Dec 5, 2025

Uh oh!

Intybyte commented Dec 5, 2025

Uh oh!

Intybyte commented Dec 12, 2025

Uh oh!

LordIdra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Intybyte commented Dec 14, 2025

Uh oh!

Seggan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LordIdra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LordIdra Dec 21, 2025

Choose a reason for hiding this comment

Uh oh!

Intybyte Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

LordIdra Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

Intybyte Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

LordIdra Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LordIdra left a comment

Choose a reason for hiding this comment

Intybyte commented Nov 26, 2025 •

edited

Loading