Add talismans #366

OhmV-IR · 2025-10-13T21:15:46Z

Implements the following:

Mob farmer talisman Mob farmer talisman #334
Hunger talisman Hunger talisman #333
Luck talisman Luck talisman #332
Hunting talisman Hunting talisman #331
Enchanting talisman Enchanting talisman #330
Bartering talisman Bartering talisman #337
Water breathing talisman Water breathing talisman #329
Farmer talisman Farmer talisman #338
Recipes for talismans
Makes tick interval of talismans configurable. Leaving Talisman ring #335 for future pr since with the Talisman class, this likely won't need to be refactored much to accommodate that.

src/main/java/io/github/pylonmc/pylon/base/content/talismans/base/Talisman.java

src/main/java/io/github/pylonmc/pylon/base/content/talismans/BarteringTalisman.java

src/main/java/io/github/pylonmc/pylon/base/content/talismans/EnchantingTalisman.java

src/main/java/io/github/pylonmc/pylon/base/content/talismans/HungerTalisman.java

src/main/resources/lang/en.yml

src/main/java/io/github/pylonmc/pylon/base/content/talismans/base/PDCKeyTalisman.java

Co-authored-by: Seggan <[email protected]>

…nchantingTalisman.java Co-authored-by: Seggan <[email protected]>

…into add-talismans

LordIdra

Nice work on this. Would be nice to have a category for these now that we have so many

Alternate item suggestions (w/ clay balls where appropriate):

hunger talisman - golden carrot
luck talisman - rabbit's foot
enchanting talisman - enchanted book without the glint
hunting talisman - skeleton skull

Other issues:

src/main/resources/lang/en.yml

src/main/java/io/github/pylonmc/pylon/base/content/talismans/EnchantingTalisman.java

LordIdra · 2025-11-18T23:19:43Z

src/main/java/io/github/pylonmc/pylon/base/content/talismans/EnchantingTalisman.java

This talisman flat out does not seem to work; cannot get it to increase any enchantment levels by one, and choosing the first enchantment from the list with a full enchanting table causes the level to be decreased by one lol

I've gotten it to work. Problem is that since we're using the enchanting table seed for the rng seed of the talisman, it will only up the same enchantments over and over again, in my case sharpness 1 -> 2 and bane of arthropods 1 -> 2. Fixed by assigning each item that comes through an enchanting table with the talisman a uuid. The exploit I could see wrt to that is that someone nefarious could run thousands of items through the enchanting table and balloon the file size of the world. Although at 16 bytes/uuid, it would take 67,108,864 items to fill up 1GB of space which is a lot so I'm not insanely worried. It's still not perfect though, if there are 3 sharpness 1s in the same view, they will all have their levels increased by 1. This is because the chance has to be deterministic from the etable, item id, and enchant type in order for us to be able to apply the enchant in the EnchantItemEvent since we don't have access to the EnchantmentOffer order.

There are much easier ways to inflate file size so I would not worry about that lol. I don't quite understand what's going on here but happy as long as it works

src/main/java/io/github/pylonmc/pylon/base/content/talismans/FarmerTalisman.java

src/main/java/io/github/pylonmc/pylon/base/content/talismans/HungerTalisman.java

LordIdra · 2025-11-18T23:37:54Z

src/main/java/io/github/pylonmc/pylon/base/content/talismans/HuntingTalisman.java

Have killed a bunch of creepers/zombies/etc and this does not appear to be working. Also probably needs a buff

uh idk what this is on about, like my first pig I killed I got like 4 porkchop when max is 2 w/o looting. Tried with zombies too and was getting multiple rotten flesh

src/main/resources/lang/en.yml

LordIdra · 2025-11-25T00:32:42Z

(Let me know when this is ready for re-review - not sure if it is rn)

LordIdra

Sorry I didn't review earlier, I kept forgetting... but here it is

LordIdra · 2026-01-04T13:56:07Z

src/main/java/io/github/pylonmc/pylon/base/content/talismans/BarteringTalisman.java

+import java.util.concurrent.ThreadLocalRandom;
+
+public class BarteringTalisman extends PDCKeyTalisman<Float, Float> {
+    public static final NamespacedKey BARTERING_TALISMAN_KEY = new NamespacedKey(PylonBase.getInstance(), "bartering_talisman");


Just FYI - you can use BaseUtils.baseKey("bartering_talisman") here. Won't comment on the other instances; up to you if you change this, it's not a big deal

LordIdra · 2026-01-04T13:56:33Z

src/main/java/io/github/pylonmc/pylon/base/BasePages.java

        }
    };

+    public static final SimpleStaticGuidePage TALISMANS = new SimpleStaticGuidePage(baseKey("talismans"), Material.TOTEM_OF_UNDYING);


This page is missing a translation key

LordIdra · 2026-01-04T13:56:45Z

src/main/java/io/github/pylonmc/pylon/base/BasePages.java


        PylonGuide.getRootPage().addPage(BUILDING);
        PylonGuide.getRootPage().addPage(CREATIVE_ITEMS);
+        PylonGuide.getRootPage().addPage(TALISMANS);


Would make more sense to have this after 'combat' in the guide

LordIdra · 2026-01-04T13:58:15Z

src/main/java/io/github/pylonmc/pylon/base/BaseItems.java

    }

+    public static final ItemStack HUNGER_TALISMAN_SIMPLE = ItemStackBuilder.pylon(Material.CLAY_BALL, BaseKeys.HUNGER_TALISMAN_SIMPLE)
+            .set(DataComponentTypes.ITEM_MODEL, Material.CLAY_BALL.getDefaultData(DataComponentTypes.ITEM_MODEL))


Maybe a better item would be cake, pumpkin pie, golden apple, or something? Clay ball doesn't feel right

LordIdra · 2026-01-04T13:59:26Z

src/main/java/io/github/pylonmc/pylon/base/content/talismans/base/AttributeTalisman.java

Just a little convention thing, but we don't really use base folders - I'd suggest just moving the folders in content/base to content/talismans

LordIdra · 2026-01-04T14:26:14Z

src/main/resources/lang/en.yml

General UI thing, might be better to separate out the whole 'while your inventory' part, maybe something like

<arrow> Gain saturation and hunger every %period% <arrow> Only works while in your inventory

Some of the wording is really awkward as it stands ('Expands your lungs so you can breathe longer underwater while in your inventory')

LordIdra · 2026-01-04T14:26:39Z

src/main/resources/lang/en.yml

+  hunger_talisman_simple:
+    name: "Simple Hunger Talisman"
+    lore: |-
+      <arrow> Gain saturation and hunger every %period% while in your inventory


'Gain' -> 'Increases your'

LordIdra · 2026-01-04T14:27:04Z

src/main/resources/lang/en.yml

+  farmer_talisman_simple:
+    name: "Simple Farming Talisman"
+    lore: |-
+      <arrow> Gain a small chance to get an extra crop drop while in your inventory


Maybe reword to 'Gives you a chance to get an extra drop when breaking a crop' for slightly better clarity

LordIdra · 2026-01-04T14:31:28Z

src/main/resources/lang/en.yml

Another little UI thing: maybe instead of having stuff like 'Change for extra item', 'Chance to not consume gold' etc you could just write 'Success rate'. Would be a bit more clear and consistent and might allow you to simplify some of the talisman descriptions too as you wouldn't need to mention 'Gain a chance to...'

LordIdra · 2026-01-04T14:32:15Z

src/main/resources/lang/en.yml

+  luck_talisman_advanced:
+    name: "Advanced Luck Talisman"
+    lore: |-
+      <arrow> Makes you a much luckier ducky while in your inventory


Needs clarification on what the heck this means in practice

OhmV-IR added 16 commits October 7, 2025 13:59

migrate health talisman to inventory ticker

e4d017e

try fix bug

034df8e

actually fix

4a8abdf

use weak to not leak mem

27c763f

generify talisman code

4aab043

fix name scheme of methods

63ddf2c

add hunger talisman

bbb0283

hunger talisman

961ae83

pr comments

1d9d964

adapt to changes in inv ticker

f9e0881

Merge branch 'master' into generify-talisman-code

f69cbb4

Merge branch 'generify-talisman-code' into add-talismans

92b5c8f

add research

0caa2cd

fix compile

707295a

surely this time

695e496

make talisman tick interval configurable

9a95fdd

OhmV-IR changed the title ~~Add talismans~~ [ref:add-inventory-ticker] Add talismans Oct 13, 2025

OhmV-IR added 2 commits October 13, 2025 17:16

stop using weak hash map where it's not needed

0caaa8f

stop using weak hash map where it's not needed

deb19b0

This was linked to issues Oct 13, 2025

Water breathing talisman #329

Open

Enchanting talisman #330

Open

Hunting talisman #331

Open

Luck talisman #332

Open

Hunger talisman #333

Open

Mob farmer talisman #334

Open

Bartering talisman #337

Open

Farmer talisman #338

Open

OhmV-IR added 3 commits October 14, 2025 12:19

farmer talisman

daade82

bartering talisman (not tested)

a714c50

water breathing talisman (also not tested yet)

ecc1425

OhmV-IR mentioned this pull request Nov 10, 2025

Generify talisman code #351

Closed

OhmV-IR changed the base branch from generify-talisman-code to master November 10, 2025 01:56

refactorrrr

e799ac9

Seggan requested changes Nov 12, 2025

View reviewed changes

OhmV-IR and others added 6 commits November 14, 2025 12:06

some pr comments

634d1af

Update src/main/resources/lang/en.yml

a352843

Co-authored-by: Seggan <[email protected]>

camelcase pdc talisman

3005045

Update src/main/java/io/github/pylonmc/pylon/base/content/talismans/E…

9c2e1b7

…nchantingTalisman.java Co-authored-by: Seggan <[email protected]>

Merge branch 'add-talismans' of https://github.com/pylonmc/pylon-base …

0cfda02

…into add-talismans

fix seggan's bad code smh

35d7f1b

OhmV-IR force-pushed the add-talismans branch from f5753c1 to 35d7f1b Compare November 14, 2025 17:45

Seggan approved these changes Nov 17, 2025

View reviewed changes

LordIdra requested changes Nov 18, 2025

View reviewed changes

LordIdra reviewed Nov 18, 2025

View reviewed changes

src/main/resources/lang/en.yml Show resolved Hide resolved

OhmV-IR added 5 commits November 19, 2025 08:05

add category and change material types

96420f2

add <white> tag to water breathing talismans

5c1605b

same material for all health talismans

75d91ff

balancing and langfile fixes

db57307

avoid percent floating point error in lore

7b5e0fe

OhmV-IR changed the title ~~Add talismans~~ [ref:percent-add-sf] Add talismans Nov 19, 2025

OhmV-IR added 2 commits November 19, 2025 11:40

Merge branch 'master' into add-talismans

1569dfa

omg im dumb

751326d

OhmV-IR changed the title ~~[ref:percent-add-sf] Add talismans~~ Add talismans Nov 19, 2025

fix build

7d89daa

OhmV-IR added 3 commits January 1, 2026 09:15

Merge branch 'master' into add-talismans

da47d9f

fix enchanting talisman

df78289

fix hunger talisman and mega nerf it

84a1716

OhmV-IR requested a review from LordIdra January 1, 2026 16:26

LordIdra requested changes Jan 4, 2026

View reviewed changes

Add talismans #366

Are you sure you want to change the base?

Add talismans #366

Conversation

OhmV-IR commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LordIdra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OhmV-IR Jan 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LordIdra commented Nov 25, 2025

Uh oh!

LordIdra left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

OhmV-IR commented Oct 13, 2025 •

edited

Loading

OhmV-IR Jan 1, 2026 •

edited

Loading