Add talismans #366
Merged
Add talismans #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 13, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Contributor
|
(Let me know when this is ready for re-review - not sure if it is rn) |
LordIdra
requested changes
Jan 4, 2026
Contributor
LordIdra
left a comment
LordIdra
left a comment
There was a problem hiding this comment.
Sorry I didn't review earlier, I kept forgetting... but here it is
src/main/java/io/github/pylonmc/pylon/base/content/talismans/BarteringTalisman.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/pylonmc/pylon/base/content/talismans/AttributeTalisman.java
Show resolved
Hide resolved
src/main/resources/lang/en.yml
Outdated
| luck_talisman_advanced: | ||
| name: "Advanced Luck Talisman" | ||
| lore: |- | ||
| <arrow> Makes you a much luckier ducky while in your inventory |
Contributor
There was a problem hiding this comment.
Needs clarification on what the heck this means in practice
Contributor
Author
There was a problem hiding this comment.
not entirely sure myself. I imagine it's a similar effect to what a luck potion does. Minecraft wiki says it affects drop tables by making you more likely to get higher quality items. updated the text for that explanation
LordIdra
approved these changes
Jan 5, 2026
Contributor
There was a problem hiding this comment.
'only works when in your inventory' should go before any attributes (by convention)
src/main/resources/lang/en.yml
Outdated
Comment on lines
1576
to
1594
| enchanting_talisman_simple: | ||
| name: "Simple Enchanting Talisman" | ||
| lore: |- | ||
| <arrow> Improves your odds of getting higher level enchants from the enchanting table | ||
| <arrow> <attr>Chance of incrementing enchantment level by 1:</attr> %bonus_level_chance% | ||
| <arrow> Only works while in your inventory | ||
| enchanting_talisman_advanced: | ||
| name: "Advanced Enchanting Talisman" | ||
| lore: |- | ||
| <arrow> Improves your odds of getting higher level enchants from the enchanting table | ||
| <arrow> <attr>Chance of incrementing enchantment level by 1:</attr> %bonus_level_chance% | ||
| <arrow> Only works while in your inventory | ||
| enchanting_talisman_ultimate: | ||
| name: "Ultimate Enchanting Talisman" | ||
| lore: |- | ||
| <arrow> Improves your odds of getting higher level enchants from the enchanting table | ||
| <arrow> <attr>Chance of incrementing enchantment level by 1:</attr> %bonus_level_chance% |
Contributor
There was a problem hiding this comment.
These 3 have blue names due to their material - you can fix by putting <white> before their name
Comment on lines
1597
to
1617
| hunting_talisman_simple: | ||
| name: "Simple Hunting Talisman" | ||
| lore: |- | ||
| <arrow> Grants you a chance to get an extra item for each drop when you kill a mob | ||
| <arrow> <attr>Chance for extra item:</attr> %bonus_item_chance% | ||
| <arrow> Only works while in your inventory | ||
| hunting_talisman_advanced: | ||
| name: "Advanced Hunting Talisman" | ||
| lore: |- | ||
| <arrow> Grants you a chance to get an extra item for each drop when you kill a mob | ||
| <arrow> <attr>Chance for extra item:</attr> %bonus_item_chance% | ||
| <arrow> Only works while in your inventory | ||
| hunting_talisman_ultimate: | ||
| name: "Ultimate Hunting Talisman" | ||
| lore: |- | ||
| <arrow> Grants you a chance to get an extra item for each drop when you kill a mob | ||
| <arrow> <attr>Chance for extra item:</attr> %bonus_item_chance% | ||
| <arrow> Only works while in your inventory | ||
Contributor
There was a problem hiding this comment.
These 3 have yellow names (again just need<white> before the name)
LordIdra
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the following:
Makes tick interval of talismans configurable. Leaving Talisman ring #335 for future pr since with the Talisman class, this likely won't need to be refactored much to accommodate that.