Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter fallback for source-roots #9967

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

akamat10
Copy link
Contributor

@akamat10 akamat10 commented Sep 25, 2024

Type of Changes

Type
✨ New feature
📜 Docs

Description

Alter fallback for source-roots as discussed in #9955. This simplifies the import discovery logic, makes it easier to understand and supports the discovery process for more usecases (for example, src-layout or in cases where imported modules may be in a different directory from the files to be linted)

TODO:

  • Changelog
  • Documentation

Update changelog and documentation

Closes #9955

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.80%. Comparing base (c0ecd70) to head (fed3e42).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
pylint/lint/expand_modules.py 83.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9967      +/-   ##
==========================================
- Coverage   95.80%   95.80%   -0.01%     
==========================================
  Files         174      174              
  Lines       18934    18939       +5     
==========================================
+ Hits        18140    18144       +4     
- Misses        794      795       +1     
Files with missing lines Coverage Δ
pylint/lint/pylinter.py 96.65% <ø> (ø)
pylint/pyreverse/main.py 93.75% <ø> (ø)
pylint/lint/expand_modules.py 94.44% <83.33%> (-0.85%) ⬇️

This comment has been minimized.

@akamat10 akamat10 force-pushed the disable_legacy_for_source_roots branch from 648b52c to 2c0c0d6 Compare September 29, 2024 05:28
@akamat10 akamat10 marked this pull request as ready for review September 29, 2024 05:55
@akamat10 akamat10 requested a review from DudeNr33 as a code owner September 29, 2024 05:55

This comment has been minimized.

@DudeNr33 DudeNr33 removed their request for review September 29, 2024 13:51
@DudeNr33
Copy link
Collaborator

As this is not primarily about pyreverse, I have unassigned me from the review.

@Pierre-Sassoulas Pierre-Sassoulas added Needs review 🔍 Needs to be reviewed by one or multiple more persons Import system Skip news 🔇 This change does not require a changelog entry labels Sep 29, 2024
@akamat10 akamat10 force-pushed the disable_legacy_for_source_roots branch from 2bae088 to 6ef3156 Compare September 29, 2024 16:55

This comment has been minimized.

Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit fed3e42

@DanielNoord
Copy link
Collaborator

@akamat10 Can you tag me when this is ready for review?

@akamat10
Copy link
Contributor Author

akamat10 commented Oct 1, 2024

Will do!

@jacobtylerwalls
Copy link
Member

Hi @akamat10 👋

Just checking in on this PR. Do you think you'll have the chance to pick up where you left off? pylint main is now compatible with astroid main, btw.

@akamat10
Copy link
Contributor Author

Yes I would love to. Haven't had the chance the last few months as I got busy with some life changes. Also, when I last looked at it, the regression test failures were a little tricky to unravel trying to understand the intent of the test and some unrelated to my changes in the main branch. I will be able to look at it starting March 1st. What kind of timelines do you have in mind for the release?

@jacobtylerwalls
Copy link
Member

The last couple years we've timed the feature release to add compatibility with a new python version in early October, so assuming we do that again you will have plenty of time :)

@akamat10
Copy link
Contributor Author

Ok sounds good. I will have some update in the first week of March.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Import system Needs review 🔍 Needs to be reviewed by one or multiple more persons Skip news 🔇 This change does not require a changelog entry
Projects
None yet
5 participants