Skip to content

Conversation

jacobtylerwalls
Copy link
Member

No description provided.

@jacobtylerwalls jacobtylerwalls added this to the 4.0.0 milestone Sep 23, 2025
@jacobtylerwalls jacobtylerwalls added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Sep 23, 2025
@jacobtylerwalls
Copy link
Member Author

@zenlyj would you be up for fixing test failures here relating to the new astroid constraint? 🙏

Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.95%. Comparing base (0871a4d) to head (e51e9b9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10585   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         176      176           
  Lines       19476    19476           
=======================================
  Hits        18689    18689           
  Misses        787      787           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This comment has been minimized.

@zenlyj
Copy link
Contributor

zenlyj commented Sep 23, 2025

@jacobtylerwalls sure thing, let me look into this one

@Pierre-Sassoulas
Copy link
Member

The primer is looking very good !

@jacobtylerwalls jacobtylerwalls changed the title Bump astroid to 4.0.0b3 Bump astroid to 4.0.0rc0 Sep 29, 2025
Copy link
Contributor

🤖 Effect of this PR on checked open source code: 🤖

Effect on astroid:
The following messages are now emitted:

  1. useless-suppression:
    Useless suppression of 'unsubscriptable-object'
    https://github.com/pylint-dev/astroid/blob/166f4445c7b394c219f0e1e402edb62a682147da/astroid/interpreter/_import/util.py#L86

The following messages are no longer emitted:

  1. suppressed-message:
    Suppressed 'unsubscriptable-object' (from line 86)
    https://github.com/pylint-dev/astroid/blob/166f4445c7b394c219f0e1e402edb62a682147da/astroid/interpreter/_import/util.py#L87

Effect on home-assistant:
The following messages are no longer emitted:

  1. unsubscriptable-object:
    Value 'err.exceptions' is unsubscriptable
    https://github.com/home-assistant/core/blob/281a137ff547a451882d9306e9db8c67dbc64080/homeassistant/components/mcp/coordinator.py#L56
  2. not-callable:
    remove is not callable
    https://github.com/home-assistant/core/blob/281a137ff547a451882d9306e9db8c67dbc64080/homeassistant/components/duckdns/__init__.py#L150
  3. not-callable:
    delay_cancel is not callable
    https://github.com/home-assistant/core/blob/281a137ff547a451882d9306e9db8c67dbc64080/homeassistant/components/template/trigger.py#L87
  4. not-callable:
    delay_cancel is not callable
    https://github.com/home-assistant/core/blob/281a137ff547a451882d9306e9db8c67dbc64080/homeassistant/components/template/trigger.py#L165
  5. not-callable:
    listener is not callable
    https://github.com/home-assistant/core/blob/281a137ff547a451882d9306e9db8c67dbc64080/homeassistant/components/airgradient/sensor.py#L257
  6. unsubscriptable-object:
    Value 'eg.exceptions' is unsubscriptable
    https://github.com/home-assistant/core/blob/281a137ff547a451882d9306e9db8c67dbc64080/homeassistant/components/ring/coordinator.py#L123
  7. not-callable:
    self.new_home_callback is not callable
    https://github.com/home-assistant/core/blob/281a137ff547a451882d9306e9db8c67dbc64080/homeassistant/components/point/coordinator.py#L46
  8. not-callable:
    self.async_extra_update is not callable
    https://github.com/home-assistant/core/blob/281a137ff547a451882d9306e9db8c67dbc64080/homeassistant/components/samsungtv/coordinator.py#L63
  9. not-callable:
    remove is not callable
    https://github.com/home-assistant/core/blob/281a137ff547a451882d9306e9db8c67dbc64080/homeassistant/components/saj/sensor.py#L175
  10. not-callable:
    unsub_pending is not callable
    https://github.com/home-assistant/core/blob/281a137ff547a451882d9306e9db8c67dbc64080/homeassistant/components/google_assistant/report_state.py#L203

Effect on black:
The following messages are no longer emitted:

  1. not-callable:
    visitf is not callable
    https://github.com/psf/black/blob/903bef54aa72e111c034ccec9997aac82bafbacc/src/black/nodes.py#L173

Effect on pytest:
The following messages are now emitted:

  1. missing-raises-doc:
    "Skipped" not documented as being raised
    https://github.com/pytest-dev/pytest/blob/bd7d709503adbe576f0120e36849eeccebe74e5b/src/_pytest/outcomes.py#L199

The following messages are no longer emitted:

  1. unsubscriptable-object:
    Value 'pypy_version_info' is unsubscriptable
    https://github.com/pytest-dev/pytest/blob/bd7d709503adbe576f0120e36849eeccebe74e5b/src/_pytest/terminal.py#L838
  2. unsubscriptable-object:
    Value 'pypy_version_info' is unsubscriptable
    https://github.com/pytest-dev/pytest/blob/bd7d709503adbe576f0120e36849eeccebe74e5b/src/_pytest/terminal.py#L839

Effect on django:
The following messages are no longer emitted:

  1. consider-iterating-dictionary:
    Consider iterating the dictionary directly instead of calling .keys()
    https://github.com/django/django/blob/be581ff473e8ade6365975db2df602f295a4cb4b/django/contrib/auth/checks.py#L162
  2. not-a-mapping:
    Non-mapping value cls._overridden_settings is used in a mapping context
    https://github.com/django/django/blob/be581ff473e8ade6365975db2df602f295a4cb4b/django/test/testcases.py#L222
  3. not-an-iterable:
    Non-iterable value cls.fixtures is used in an iterating context
    https://github.com/django/django/blob/be581ff473e8ade6365975db2df602f295a4cb4b/django/test/testcases.py#L1227
  4. not-an-iterable:
    Non-iterable value cls.fixtures is used in an iterating context
    https://github.com/django/django/blob/be581ff473e8ade6365975db2df602f295a4cb4b/django/test/testcases.py#L1430
  5. not-an-iterable:
    Non-iterable value cls.fixtures is used in an iterating context
    https://github.com/django/django/blob/be581ff473e8ade6365975db2df602f295a4cb4b/django/test/testcases.py#L1484

Effect on pandas:
The following messages are no longer emitted:

  1. not-callable:
    memory_usage is not callable
    https://github.com/pandas-dev/pandas/blob/e97a56e746f8cdeabf7e83ec83455cbf5386c909/pandas/core/base.py#L131

Effect on sentry:
The following messages are now emitted:

  1. redefined-variable-type:
    Redefinition of name type from str to list
    https://github.com/getsentry/sentry/blob/d5fc0b31fb64d523f0fad14479bc125243626de0/src/sentry/search/events/filter.py#L609

The following messages are no longer emitted:

  1. unsubscriptable-object:
    Value 'munged' is unsubscriptable
    https://github.com/getsentry/sentry/blob/d5fc0b31fb64d523f0fad14479bc125243626de0/src/sentry/issues/ownership/grammar.py#L140
  2. unsubscriptable-object:
    Value 'munged' is unsubscriptable
    https://github.com/getsentry/sentry/blob/d5fc0b31fb64d523f0fad14479bc125243626de0/src/sentry/issues/ownership/grammar.py#L141
  3. unsubscriptable-object:
    Value 'munged' is unsubscriptable
    https://github.com/getsentry/sentry/blob/d5fc0b31fb64d523f0fad14479bc125243626de0/src/sentry/utils/committers.py#L357
  4. no-member:
    Instance of 'dict' has no 'get_many' member
    https://github.com/getsentry/sentry/blob/d5fc0b31fb64d523f0fad14479bc125243626de0/src/sentry/services/nodestore/base.py#L286
  5. no-member:
    Instance of 'dict' has no 'set_many' member
    https://github.com/getsentry/sentry/blob/d5fc0b31fb64d523f0fad14479bc125243626de0/src/sentry/services/nodestore/base.py#L296
  6. no-member:
    Instance of 'dict' has no 'delete' member
    https://github.com/getsentry/sentry/blob/d5fc0b31fb64d523f0fad14479bc125243626de0/src/sentry/services/nodestore/base.py#L300
  7. no-member:
    Instance of 'dict' has no 'delete_many' member
    https://github.com/getsentry/sentry/blob/d5fc0b31fb64d523f0fad14479bc125243626de0/src/sentry/services/nodestore/base.py#L304

This comment was generated for commit e51e9b9

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@Pierre-Sassoulas Pierre-Sassoulas merged commit a0e601d into pylint-dev:main Sep 29, 2025
44 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/bump-astroid branch September 29, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants