Skip to content

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Sep 22, 2025

Followup to #10580 (comment)

@cdce8p cdce8p added this to the 4.0.0 milestone Sep 22, 2025
@cdce8p cdce8p mentioned this pull request Sep 22, 2025
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.95%. Comparing base (f0b41c0) to head (90d86ad).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10583      +/-   ##
==========================================
+ Coverage   95.93%   95.95%   +0.02%     
==========================================
  Files         176      176              
  Lines       19471    19455      -16     
==========================================
- Hits        18679    18668      -11     
+ Misses        792      787       -5     
Files with missing lines Coverage Δ
pylint/checkers/base/comparison_checker.py 98.59% <100.00%> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This comment has been minimized.

@Pierre-Sassoulas
Copy link
Member

402 occurrence on the whole of github, possibly 190 import mistakingly identified as numpy (but they probably don't have a NaN ?)

@cdce8p
Copy link
Member Author

cdce8p commented Sep 23, 2025

Remove and see if someone complains? We can always revert it later. Or we just leave it as is.

@Pierre-Sassoulas Pierre-Sassoulas added Needs review 🔍 Needs to be reviewed by one or multiple more persons Needs decision 🔒 Needs a decision before implemention or rejection and removed Needs review 🔍 Needs to be reviewed by one or multiple more persons labels Sep 23, 2025
DanielNoord
DanielNoord previously approved these changes Sep 23, 2025
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to me!

Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 90d86ad

@Pierre-Sassoulas Pierre-Sassoulas merged commit 42c0131 into pylint-dev:main Sep 24, 2025
44 checks passed
@cdce8p cdce8p deleted the numpy-import-alias branch September 24, 2025 08:07
@cdce8p cdce8p removed the Needs decision 🔒 Needs a decision before implemention or rejection label Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants