-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove support for nmp as import alias for numpy #10583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10583 +/- ##
==========================================
+ Coverage 95.93% 95.95% +0.02%
==========================================
Files 176 176
Lines 19471 19455 -16
==========================================
- Hits 18679 18668 -11
+ Misses 792 787 -5
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
402 occurrence on the whole of github, possibly 190 import mistakingly identified as numpy (but they probably don't have a NaN ?) |
Remove and see if someone complains? We can always revert it later. Or we just leave it as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems sensible to me!
Co-authored-by: Pierre Sassoulas <[email protected]>
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 90d86ad |
Followup to #10580 (comment)