Skip to content

Conversation

zenlyj
Copy link
Contributor

@zenlyj zenlyj commented Sep 4, 2025

Type of Changes

Type
βœ“ πŸ› Bug fix
✨ New feature
πŸ”¨ Refactoring
πŸ“œ Docs

Description

Issue should be fixed with pylint-dev/astroid#2811. Mainly adding a regression test here.

Closes #10525

@zenlyj
Copy link
Contributor Author

zenlyj commented Sep 4, 2025

Let me know if I need include a changelog here, there is already one on astroid side so I am unsure if we need one here as well

@zenlyj zenlyj added the Needs astroid update Needs an astroid update (probably a release too) before being mergable label Sep 4, 2025
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 4.0.0, 3.3.9 Sep 4, 2025
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! pylint is the "front", I think there's a lot less person reading astroid's release note, so it's good to have a changelog in pylint for astroid changes with pylint consequences.

@Pierre-Sassoulas Pierre-Sassoulas added the Blocked 🚧 Blocked by a particular issue label Sep 4, 2025
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have attrs as a test dependency.

Considering we already have a regression test in astroid, should we just leave this out of pylint and consider the issue fixed?

@Pierre-Sassoulas
Copy link
Member

Fair enough, I would be okay with adding attr as a dev dependencie too, there's always issue with it it seems.

@zenlyj
Copy link
Contributor Author

zenlyj commented Oct 1, 2025

Let's go with leaving this test out, probably cleaner that way as well, rather than adding a file dedicated to a single issue. I'll go ahead and close this PR and put the issue as completed.

@zenlyj zenlyj closed this Oct 1, 2025
@zenlyj zenlyj deleted the 10525-fp branch October 1, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked 🚧 Blocked by a particular issue Needs astroid update Needs an astroid update (probably a release too) before being mergable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

false positive invalid-name on attrs classvar
3 participants