Fix crash with dataclasses that have __init_subclass__ modifying __init__ #10520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash in pylint when processing dataclasses that use
__init_subclass__to modify the__init__method. The issue occurred when inheriting from a generic dataclass without providing explicit type parameters.Problem
When
__init_subclass__modifies the__init__method by assignment (e.g.,cls.__init__ = wrapped_init), astroid's dataclass brain module would crash with anAttributeErrorbecause it expected__init__to always be aFunctionDefnode, but after reassignment it becomes anAssignAttrnode.Solution
Added a monkey patch in
pylint/checkers/dataclass_checker.pythat replaces astroid's_find_arguments_from_base_classesfunction with a version that safely handles non-FunctionDefnodes. When__init__has been modified by__init_subclass__, the patched function simply skips processing that base class rather than crashing.The fix is minimal and surgical:
__init_subclass__modifies__init__Testing
Added a comprehensive functional test (
dataclass_generic_init_subclass.py) that verifies the fix works for both generic and non-generic dataclass inheritance scenarios. All existing dataclass and regression tests continue to pass.Fixes #10519.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.